Review Request 110383: Implement Distraction-Free mode for Words and Author.

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110383/#review32337
-----------------------------------------------------------

Ship it!


I have tried this and it works very well.  Good job!  And very nice code too, I may add.

If you fix the small issues that I have pointed out below you can merge, you don't have to re-review.


libs/widgets/KoFloatingMessage.h
<http://git.reviewboard.kde.org/r/110383/#comment24055>

    This here is a problem.  All widgets in libs/widgets should be under the LGPL. Can perhaps the authors be persuaded to relicense it?



words/part/KWView.h
<http://git.reviewboard.kde.org/r/110383/#comment24056>

    typo: distraction
    Also: double space



words/part/KWView.h
<http://git.reviewboard.kde.org/r/110383/#comment24057>

    type: Distraction



words/part/KWView.h
<http://git.reviewboard.kde.org/r/110383/#comment24058>

    can -> come



words/part/KWView.cpp
<http://git.reviewboard.kde.org/r/110383/#comment24059>

    I think the name of the parameter should perhaps be "status" instead of "toggled". The reason is that it's always toggled (it's a toggle action after all), which means that the name doesn't give any clue.



words/part/author/author.rc
<http://git.reviewboard.kde.org/r/110383/#comment24060>

    I think the name should be view_distractionfreemode.  The underscore is not a word separator in the name but a separator in the menu hierarchy.  The world "view" here means that it's supposed to be in the View menu.  (Unless I'm wrong in my assumption in which case you can ignore this. :) )


- Inge Wallin


On May 10, 2013, 5:54 p.m., mojtaba shahi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110383/
> -----------------------------------------------------------
> 
> (Updated May 10, 2013, 5:54 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Implement Distraction-Free mode for Words and Author.
> Added an action "View->Distractio Free Mode". This action Hide Menu bar, Tool bar, Staus bar, Dock widgets ,Vertical and horizontl scroll bar from view.
> When you switch to Distractio-Free mode it will rise a floating message say how can you get out from this view.
> I have added a "Exit Distractio-Free Mode" button to status bar that user can get back to normal view by clicking ont it. (it is visible just in DF mode)
> Staus bar will show if user moves mouse on status bar at bottom.
> Horizontal and Vertical scroll bars will show when user moves mouse on them.
> Cursor will Hide, user doesn't move mouse after 4 seconds.
> 
> 
> Diffs
> -----
> 
>   krita/plugins/tools/tool_crop/kis_tool_crop.cc 05e905b 
>   krita/ui/CMakeLists.txt 37e4635 
>   krita/ui/kis_view2.cpp 7d4c6da 
>   krita/ui/tool/kis_tool.cc 33dbbf0 
>   krita/ui/widgets/kis_floating_message.h 0d42e8b 
>   krita/ui/widgets/kis_floating_message.cpp d53e133 
>   libs/main/KoMainWindow.cpp ea45075 
>   libs/main/KoView.cpp c9c82e5 
>   libs/widgets/CMakeLists.txt 4e6e362 
>   libs/widgets/KoFloatingMessage.h PRE-CREATION 
>   libs/widgets/KoFloatingMessage.cpp PRE-CREATION 
>   words/part/KWCanvas.cpp 4252ff7 
>   words/part/KWGui.h c72234d 
>   words/part/KWGui.cpp 803e1b5 
>   words/part/KWView.h 6357876 
>   words/part/KWView.cpp 5c1cc70 
>   words/part/author/author.rc b3b187c 
>   words/part/words.rc d2269d1 
> 
> Diff: http://git.reviewboard.kde.org/r/110383/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Distraction-Free Mode
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/10/distraction-free_mode_1.png
> Distraction-Free mode with  Status bar
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/10/distraction-free_mode_2.png
> Distraction-Free mode with vertical scroll bar
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/10/distraction-free_mode_3.png
> 
> 
> Thanks,
> 
> mojtaba shahi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130510/cd83b601/attachment.htm>