Review Request 109573: remove filters/kchart/genericimageexport (unported, uncompiled)

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109573/#review29501
-----------------------------------------------------------

Ship it!


I guess that if you note the commit duly in OBSOLETE, it could be removed.

I have long wanted to implement generic image export for any shape, especially frame shape, and there is some work here that I'd rather not have to reimplement.  But will be some other time so until then just remove it.

- Inge Wallin


On March 18, 2013, 9:47 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109573/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 9:47 p.m.)
> 
> 
> Review request for Calligra and Inge Wallin.
> 
> 
> Description
> -------
> 
> Preparing the productization of the filters I found that the kchart filter genericimageexport is not built.
> 
> Its build is guarded by SHOULD_BUILD_KCHART, but that is nowhere else set/used, that is why nobody might have noticed so far.
> 
> This patch also removes filters/libdialogfilter which has been only referenced from that filter, so is not used as well.
> 
> Would note the removal in OBSOLETE.TXT as usual.
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt 8bcd640 
>   filters/kchart/CMakeLists.txt bec23fc 
>   filters/kchart/genericimageexport/CMakeLists.txt fb34b1b 
>   filters/kchart/genericimageexport/genericimageexport.h a699e80 
>   filters/kchart/genericimageexport/genericimageexport.cpp c35f896 
>   filters/kchart/genericimageexport/kchart_bmp_export.desktop 5dff846 
>   filters/kchart/genericimageexport/kchart_jpeg_export.desktop 88f9362 
>   filters/kchart/genericimageexport/kchart_mng_export.desktop 144e0d4 
>   filters/kchart/genericimageexport/kchart_png_export.desktop 5b966f2 
>   filters/kchart/genericimageexport/kchart_xbm_export.desktop 0583d1c 
>   filters/kchart/genericimageexport/kchart_xpm_export.desktop bbc0f47 
>   filters/libdialogfilter/exportsizedia.h 1f56903 
>   filters/libdialogfilter/exportsizedia.cpp e4a0a45 
> 
> Diff: http://git.reviewboard.kde.org/r/109573/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130319/7ac4cfe6/attachment.htm>