Review Request 109573: remove filters/kchart/genericimageexport (unported, uncompiled)

Friedrich W. H. Kossebau kossebau at kde.org
Mon Mar 18 21:47:29 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109573/
-----------------------------------------------------------

Review request for Calligra and Inge Wallin.


Description
-------

Preparing the productization of the filters I found that the kchart filter genericimageexport is not built.

Its build is guarded by SHOULD_BUILD_KCHART, but that is nowhere else set/used, that is why nobody might have noticed so far.

This patch also removes filters/libdialogfilter which has been only referenced from that filter, so is not used as well.

Would note the removal in OBSOLETE.TXT as usual.


Diffs
-----

  filters/CMakeLists.txt 8bcd640 
  filters/kchart/CMakeLists.txt bec23fc 
  filters/kchart/genericimageexport/CMakeLists.txt fb34b1b 
  filters/kchart/genericimageexport/genericimageexport.h a699e80 
  filters/kchart/genericimageexport/genericimageexport.cpp c35f896 
  filters/kchart/genericimageexport/kchart_bmp_export.desktop 5dff846 
  filters/kchart/genericimageexport/kchart_jpeg_export.desktop 88f9362 
  filters/kchart/genericimageexport/kchart_mng_export.desktop 144e0d4 
  filters/kchart/genericimageexport/kchart_png_export.desktop 5b966f2 
  filters/kchart/genericimageexport/kchart_xbm_export.desktop 0583d1c 
  filters/kchart/genericimageexport/kchart_xpm_export.desktop bbc0f47 
  filters/libdialogfilter/exportsizedia.h 1f56903 
  filters/libdialogfilter/exportsizedia.cpp e4a0a45 

Diff: http://git.reviewboard.kde.org/r/109573/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130318/6adc3610/attachment.htm>


More information about the calligra-devel mailing list