Review Request 109284: Normalize SIGNAL and SLOT signatures in Sheets

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109284/
-----------------------------------------------------------

Review request for Calligra and Marijn Kruisselbrink.


Description
-------

Normalize all SIGNAL and SLOT signatures in sheets.  I asked Mek beforehand and he said he liked it and would look at the diff.


Diffs
-----

  sheets/Map.cpp 66c950c 
  sheets/MapModel.cpp f2610c7 
  sheets/NamedAreaManager.cpp c980a71 
  sheets/Sheet.cpp 6ae75fa 
  sheets/SheetAccessModel.cpp 7b80318 
  sheets/commands/SpellCheckCommand.cpp c762428 
  sheets/dialogs/AddNamedAreaDialog.cpp 090ec34 
  sheets/dialogs/ConditionalDialog.cpp 2728527 
  sheets/dialogs/ConsolidateDialog.cpp d9d708b 
  sheets/dialogs/DatabaseDialog.cpp bc25c4c 
  sheets/dialogs/FormulaDialog.cpp 5d8acfb 
  sheets/dialogs/GotoDialog.cpp 9ae4be2 
  sheets/dialogs/LayoutDialog.cpp 69772dd 
  sheets/dialogs/LinkDialog.cpp f5f7332 
  sheets/dialogs/NamedAreaDialog.cpp 87d597c 
  sheets/dialogs/ShowColRowDialog.cpp 0aa073b 
  sheets/dialogs/ShowDialog.cpp e703e3d 
  sheets/dialogs/StyleManagerDialog.cpp b932002 
  sheets/interfaces/SheetAdaptor.cpp 97bd61d 
  sheets/part/CanvasItem.cpp e7577b5 
  sheets/part/Doc.cpp c9d60cf 
  sheets/part/HeaderItems.cpp b589542 
  sheets/part/HeaderWidgets.cpp 9fb14bb 
  sheets/part/View.cpp 0ad5be8 
  sheets/part/dialogs/PreferenceDialog.cpp 36a91ee 
  sheets/plugins/calendar/CalendarTool.cpp 71c4332 
  sheets/plugins/scripting/ScriptingListener.cpp 508fb5d 
  sheets/shape/SheetsEditor.cpp 2cc3247 
  sheets/shape/TableShape.cpp 43777eb 
  sheets/ui/CellEditor.cpp b0ca432 
  sheets/ui/CellToolBase.cpp 7591d7a 
  sheets/ui/FunctionCompletion.cpp b3a4d9b 
  sheets/ui/LocationComboBox.cpp 7a9d827 
  sheets/ui/MapViewModel.cpp e66b211 
  sheets/ui/RegionSelector.cpp 42e711e 

Diff: http://git.reviewboard.kde.org/r/109284/diff/


Testing
-------

It builds correctly but it should probably be tested too. I haven't done that. One risk is that the filter(s) use some connections that need to be normalized too.


Thanks,

Inge Wallin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130304/f40babe8/attachment.htm>