Review Request 109226: from allways true to (probably) what is wanted

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109226/#review28371
-----------------------------------------------------------

Ship it!


Looks good, please shipt

- Thorsten Zachmann


On March 1, 2013, 3:41 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109226/
> -----------------------------------------------------------
> 
> (Updated March 1, 2013, 3:41 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> a>=1 || a<=4 is always true. a>=1 && a<=4 not always.
> 
> 
> Diffs
> -----
> 
>   sheets/Style.cpp a3a3976 
> 
> Diff: http://git.reviewboard.kde.org/r/109226/diff/
> 
> 
> Testing
> -------
> 
> I see the same failed tests as before.
> 
>         169 - krita-ui-KisDoc2Test (Failed)
>         172 - krita-ui-FreehandStrokeTest (Failed)
>         173 - krita-ui-KisSelectionManagerTest (Failed)
>         174 - krita-ui-KisNodeManagerTest (Failed)
>         176 - krita-ui-KisNodeShapesGraphTest (Failed)
>         182 - krita-ui-KisActionManagerTest (Failed)
>         191 - krita-plugin-format-jpeg_test (Failed)
>         210 - libs-store-storage (Failed)
>         216 - libs-textlayout-TestBlockLayout (Failed)
>         229 - libs-kotext-styles-TestOpenDocumentStyle (Failed)
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130302/d66852ce/attachment.htm>