Review Request 109226: from allways true to (probably) what is wanted

Jaime Torres Amate jtamate at gmail.com
Fri Mar 1 15:41:59 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109226/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

a>=1 || a<=4 is always true. a>=1 && a<=4 not always.


Diffs
-----

  sheets/Style.cpp a3a3976 

Diff: http://git.reviewboard.kde.org/r/109226/diff/


Testing
-------

I see the same failed tests as before.

        169 - krita-ui-KisDoc2Test (Failed)
        172 - krita-ui-FreehandStrokeTest (Failed)
        173 - krita-ui-KisSelectionManagerTest (Failed)
        174 - krita-ui-KisNodeManagerTest (Failed)
        176 - krita-ui-KisNodeShapesGraphTest (Failed)
        182 - krita-ui-KisActionManagerTest (Failed)
        191 - krita-plugin-format-jpeg_test (Failed)
        210 - libs-store-storage (Failed)
        216 - libs-textlayout-TestBlockLayout (Failed)
        229 - libs-kotext-styles-TestOpenDocumentStyle (Failed)


Thanks,

Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130301/a2d4a70b/attachment.htm>


More information about the calligra-devel mailing list