Review Request 111247: add cmake flag RELEASE_BUILD, to control build of staging products and devel addons

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111247/#review35226
-----------------------------------------------------------


This review has been submitted with commit 16cac99ae3099323ff7cc601f614cac176d652d2 by Friedrich W. H. Kossebau to branch master.

- Commit Hook


On June 25, 2013, 11:01 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111247/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 11:01 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> As discussed on the ml recently the "Maintainer wanted, alive not dead" splashscreens for Karbon & Plan should be only shown in non-release builds, as plain users will just find them annoying, so possibly have a negative effect on any existing userbase.
> But there are also other things which are not wanted in release mode:
> * the plugins which are only in staging mode
> * devel tools like the textdocument inspector
> 
> I propose to enable/disable their build globally by a boolean RELEASE_BUILD flag, which either can be set on the commandline or will be estimated by the value of CMAKE_BUILD_TYPE. This can then be used to control the build of the rest.
> 
> Would any people set RELEASE_BUILD to overwrite the estimated value? Who of you would, for which reason? So should the value rather be cached, or even be stored as an option?
> 
> Okay to backport to 2.7? (originally written for 2.7, to get rid of the splashscreens in Karbon & Plan for the release)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d21b5a2 
>   cmake/modules/CalligraProductSetMacros.cmake 8e99752 
>   karbon/CMakeLists.txt cf11b06 
>   karbon/main.cpp 4b99283 
>   plan/CMakeLists.txt 7dabf7b 
>   plan/main.cpp 23622e7 
>   plugins/textshape/CMakeLists.txt 3bc3628 
> 
> Diff: http://git.reviewboard.kde.org/r/111247/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130628/c7c83e66/attachment.htm>