<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111247/">http://git.reviewboard.kde.org/r/111247/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 16cac99ae3099323ff7cc601f614cac176d652d2 by Friedrich W. H. Kossebau to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On June 25th, 2013, 11:01 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated June 25, 2013, 11:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As discussed on the ml recently the "Maintainer wanted, alive not dead" splashscreens for Karbon & Plan should be only shown in non-release builds, as plain users will just find them annoying, so possibly have a negative effect on any existing userbase.
But there are also other things which are not wanted in release mode:
* the plugins which are only in staging mode
* devel tools like the textdocument inspector
I propose to enable/disable their build globally by a boolean RELEASE_BUILD flag, which either can be set on the commandline or will be estimated by the value of CMAKE_BUILD_TYPE. This can then be used to control the build of the rest.
Would any people set RELEASE_BUILD to overwrite the estimated value? Who of you would, for which reason? So should the value rather be cached, or even be stored as an option?
Okay to backport to 2.7? (originally written for 2.7, to get rid of the splashscreens in Karbon & Plan for the release)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d21b5a2)</span></li>
<li>cmake/modules/CalligraProductSetMacros.cmake <span style="color: grey">(8e99752)</span></li>
<li>karbon/CMakeLists.txt <span style="color: grey">(cf11b06)</span></li>
<li>karbon/main.cpp <span style="color: grey">(4b99283)</span></li>
<li>plan/CMakeLists.txt <span style="color: grey">(7dabf7b)</span></li>
<li>plan/main.cpp <span style="color: grey">(23622e7)</span></li>
<li>plugins/textshape/CMakeLists.txt <span style="color: grey">(3bc3628)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111247/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>