Review Request 111031: rename all filter modules to calligra_filter_formatx2formaty (instead of current namespaceless names)

Sun Jun 16 16:41:53 BST 2013

> On June 16, 2013, 7:31 a.m., C. Boemann wrote:
> > has my support, with just a litle nag: what happens if a filter can support more than one conversion?

Hm, good question. Actually in this example patch I even had the problem already, as the mpxj2plan filter supports mpp, mpx, planner and possibly more. Escaped that problem by simply naming it ..._mpxj2plan, as the java lib mpxj.jar just provides one format to the actual filter code. No general solution though.
Perhaps just list all the formats on each side of the "2"? So e.g. the module of an imagined filter which does read both doc and docx and outputs odt and html would be named "calligra_filter_docdocx2odthtml". Other proposals?

This naming pattern is only modules which just contain a single filter anyway. In theory all those filters could also be bundled in one big module file, like it might be needed on Android etc. Or be bundled with other plugins of different types. So there would need to be another naming pattern anyway, possibly a generic "calligra_plugin_xxx", with xxx a hopefully short specific description. But for module files with just a plugin for a given type IMHO it is nicer to have the type in the naming, so for filters "calligra_filter_xxx".

- Friedrich W. H.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111031/#review34413
-----------------------------------------------------------

On June 14, 2013, 11:08 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111031/
> -----------------------------------------------------------
> 
> (Updated June 14, 2013, 11:08 p.m.)
> 
> 
> Review request for Calligra, C. Boemann, Inge Wallin, and Yue Liu.
> 
> 
> Description
> -------
> 
> As discussed now and then Calligra's libs and modules sometimes have rather generic names, like e.g. exporthtml, msooxml, textlayout, or vectorimage. It would be better behaving and possibly also easier for developers messing around in install dirs when we namespace our libs and modules and possibly also have some naming scheme where appropriate.
> 
> For a start I propose to change the names of all the filter modules, to have the prefix "calligra_filter_" and then the pattern "formatX2formatY". Attached patch gives an example for ODT/ODG/Plan related filters. If you agree with this I would continue the work to rename all remaining filters and then commit (with another review if you prefer).
> 
> I did not yet rename the desktop files, as that would need coordination with the translators and possibly should be done after 2.7.1+x release, when activity for translations of Calligra might be lower. (of course this patch is for master only, no changes for 2.7 planned. but I assume that the strings for 2.7 are somehow merged back to master?)
> 
> 
> Diffs
> -----
> 
>   filters/flow/visio/import/CMakeLists.txt faa6767 
>   filters/flow/visio/import/flow_vsdx_import.desktop e18e46d 
>   filters/plan/mpxj/import/CMakeLists.txt 49dcf0f 
>   filters/plan/mpxj/import/plan_msproject_import.desktop 98b4d3b 
>   filters/plan/mpxj/import/plan_msprojectexchange_import.desktop d0da3b4 
>   filters/plan/mpxj/import/plan_planner_import.desktop 34a25bb 
>   filters/words/applixword/CMakeLists.txt 242a0d7 
>   filters/words/applixword/words_applixword_import.desktop db65669 
>   filters/words/ascii/CMakeLists.txt 78655f9 
>   filters/words/ascii/words_ascii_export.desktop 35a2222 
>   filters/words/ascii/words_ascii_import.desktop 3aeed8e 
>   filters/words/docx/import/CMakeLists.txt aff322c 
>   filters/words/docx/import/words_docx_import.desktop e3384ad 
>   filters/words/epub/CMakeLists.txt f281c46 
>   filters/words/epub/words_epub2_export.desktop d48e543 
>   filters/words/epub/words_html_export.desktop 7ddb19b 
>   filters/words/mobi/CMakeLists.txt f7e064f 
>   filters/words/mobi/words_Mobi_export.desktop 2ee7f8b 
>   filters/words/msword-odf/CMakeLists.txt f903f75 
>   filters/words/msword-odf/words_msword-odf_import.desktop 132397f 
>   filters/words/rtf/import/CMakeLists.txt d1ac6b1 
>   filters/words/rtf/import/words_rtf_import.desktop 3f2daed 
>   filters/words/wordperfect/import/CMakeLists.txt c919657 
>   filters/words/wordperfect/import/words_wpd_import.desktop e46fbae 
>   filters/words/works/import/CMakeLists.txt 2ada91b 
>   filters/words/works/import/words_wps_import.desktop 27b4021 
> 
> Diff: http://git.reviewboard.kde.org/r/111031/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130616/3d7cea04/attachment.htm>