<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111031/">http://git.reviewboard.kde.org/r/111031/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 16th, 2013, 7:31 a.m. UTC, <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">has my support, with just a litle nag: what happens if a filter can support more than one conversion?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm, good question. Actually in this example patch I even had the problem already, as the mpxj2plan filter supports mpp, mpx, planner and possibly more. Escaped that problem by simply naming it ..._mpxj2plan, as the java lib mpxj.jar just provides one format to the actual filter code. No general solution though.
Perhaps just list all the formats on each side of the "2"? So e.g. the module of an imagined filter which does read both doc and docx and outputs odt and html would be named "calligra_filter_docdocx2odthtml". Other proposals?
This naming pattern is only modules which just contain a single filter anyway. In theory all those filters could also be bundled in one big module file, like it might be needed on Android etc. Or be bundled with other plugins of different types. So there would need to be another naming pattern anyway, possibly a generic "calligra_plugin_xxx", with xxx a hopefully short specific description. But for module files with just a plugin for a given type IMHO it is nicer to have the type in the naming, so for filters "calligra_filter_xxx".</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On June 14th, 2013, 11:08 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, C. Boemann, Inge Wallin, and Yue Liu.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated June 14, 2013, 11:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As discussed now and then Calligra's libs and modules sometimes have rather generic names, like e.g. exporthtml, msooxml, textlayout, or vectorimage. It would be better behaving and possibly also easier for developers messing around in install dirs when we namespace our libs and modules and possibly also have some naming scheme where appropriate.
For a start I propose to change the names of all the filter modules, to have the prefix "calligra_filter_" and then the pattern "formatX2formatY". Attached patch gives an example for ODT/ODG/Plan related filters. If you agree with this I would continue the work to rename all remaining filters and then commit (with another review if you prefer).
I did not yet rename the desktop files, as that would need coordination with the translators and possibly should be done after 2.7.1+x release, when activity for translations of Calligra might be lower. (of course this patch is for master only, no changes for 2.7 planned. but I assume that the strings for 2.7 are somehow merged back to master?)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/flow/visio/import/CMakeLists.txt <span style="color: grey">(faa6767)</span></li>
<li>filters/flow/visio/import/flow_vsdx_import.desktop <span style="color: grey">(e18e46d)</span></li>
<li>filters/plan/mpxj/import/CMakeLists.txt <span style="color: grey">(49dcf0f)</span></li>
<li>filters/plan/mpxj/import/plan_msproject_import.desktop <span style="color: grey">(98b4d3b)</span></li>
<li>filters/plan/mpxj/import/plan_msprojectexchange_import.desktop <span style="color: grey">(d0da3b4)</span></li>
<li>filters/plan/mpxj/import/plan_planner_import.desktop <span style="color: grey">(34a25bb)</span></li>
<li>filters/words/applixword/CMakeLists.txt <span style="color: grey">(242a0d7)</span></li>
<li>filters/words/applixword/words_applixword_import.desktop <span style="color: grey">(db65669)</span></li>
<li>filters/words/ascii/CMakeLists.txt <span style="color: grey">(78655f9)</span></li>
<li>filters/words/ascii/words_ascii_export.desktop <span style="color: grey">(35a2222)</span></li>
<li>filters/words/ascii/words_ascii_import.desktop <span style="color: grey">(3aeed8e)</span></li>
<li>filters/words/docx/import/CMakeLists.txt <span style="color: grey">(aff322c)</span></li>
<li>filters/words/docx/import/words_docx_import.desktop <span style="color: grey">(e3384ad)</span></li>
<li>filters/words/epub/CMakeLists.txt <span style="color: grey">(f281c46)</span></li>
<li>filters/words/epub/words_epub2_export.desktop <span style="color: grey">(d48e543)</span></li>
<li>filters/words/epub/words_html_export.desktop <span style="color: grey">(7ddb19b)</span></li>
<li>filters/words/mobi/CMakeLists.txt <span style="color: grey">(f7e064f)</span></li>
<li>filters/words/mobi/words_Mobi_export.desktop <span style="color: grey">(2ee7f8b)</span></li>
<li>filters/words/msword-odf/CMakeLists.txt <span style="color: grey">(f903f75)</span></li>
<li>filters/words/msword-odf/words_msword-odf_import.desktop <span style="color: grey">(132397f)</span></li>
<li>filters/words/rtf/import/CMakeLists.txt <span style="color: grey">(d1ac6b1)</span></li>
<li>filters/words/rtf/import/words_rtf_import.desktop <span style="color: grey">(3f2daed)</span></li>
<li>filters/words/wordperfect/import/CMakeLists.txt <span style="color: grey">(c919657)</span></li>
<li>filters/words/wordperfect/import/words_wpd_import.desktop <span style="color: grey">(e46fbae)</span></li>
<li>filters/words/works/import/CMakeLists.txt <span style="color: grey">(2ada91b)</span></li>
<li>filters/words/works/import/words_wps_import.desktop <span style="color: grey">(27b4021)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111031/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>