Review Request 111667: Make libcalligrachartshape a static lib, rename to libchartshapecore and no longer install it

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111667/#review36565
-----------------------------------------------------------

Ship it!


Yeah, this doesn't need to be a shared library.  My only question was about the interfaces in interfaces/ and if we still need to export some classes but you answered that on IRC.

- Inge Wallin


On July 23, 2013, 9:30 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111667/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 9:30 p.m.)
> 
> 
> Review request for Calligra and Inge Wallin.
> 
> 
> Description
> -------
> 
> Because libcalligrachartshape is no longer shared with anything else that is installed, there is no need to have it as a shared lib with exported symbols.
> 
> The only other units using this lib are the tests, and they can just link the lib as a static lib.
> 
> So attached patch...
> * removes kchart_export.h and all usages of the export macro
> * renames libcalligrachartshape to libchartshapecore
> * makes the lib static instead of shared
> * no longer install it
> 
> Result:
> + one lib less installed
> + chart shape loads slightly faster
> 
> 
> Diffs
> -----
> 
>   plugins/chartshape/ARCHITECTURE 028e71a 
>   plugins/chartshape/Axis.h d24e4aa 
>   plugins/chartshape/CMakeLists.txt 28c71a6 
>   plugins/chartshape/CellRegion.h 6504c15 
>   plugins/chartshape/ChartConfigWidget.h c0b825d 
>   plugins/chartshape/ChartPart.h a12a733 
>   plugins/chartshape/ChartProxyModel.h 4abe2ff 
>   plugins/chartshape/ChartShape.h dedbf5d 
>   plugins/chartshape/ChartTableModel.h 0a09c1f 
>   plugins/chartshape/ChartTool.h c731542 
>   plugins/chartshape/ChartToolFactory.h b9d1b49 
>   plugins/chartshape/DataSet.h 71583e7 
>   plugins/chartshape/KDChartModel.h b1a984d 
>   plugins/chartshape/Legend.h a733b38 
>   plugins/chartshape/PlotArea.h 6d0064a 
>   plugins/chartshape/TableSource.h 2da46a7 
>   plugins/chartshape/kchart_export.h b813a64 
>   plugins/chartshape/tests/CMakeLists.txt 98f5c6c 
>   plugins/chartshape/tests/odf/bubble-chart/CMakeLists.txt 6eaa98b 
>   plugins/chartshape/tests/odf/bug239802/CMakeLists.txt 83b8f42 
>   plugins/chartshape/tests/odf/default-calligra-chart/CMakeLists.txt 9f6140b 
>   plugins/chartshape/tests/odf/default-ooo-chart/CMakeLists.txt 57cd5c2 
>   plugins/chartshape/tests/odf/me07_percentage_stacked_bar_chart/CMakeLists.txt 0272951 
>   plugins/chartshape/tests/odf/template/CMakeLists.txt 0adbaf0 
> 
> Diff: http://git.reviewboard.kde.org/r/111667/diff/
> 
> 
> Testing
> -------
> 
> Charts still work fine in Sheets (including special controls) and elsewhere.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130726/793c857a/attachment.htm>