<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111667/">http://git.reviewboard.kde.org/r/111667/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, this doesn't need to be a shared library. My only question was about the interfaces in interfaces/ and if we still need to export some classes but you answered that on IRC.</pre>
<br />
<p>- Inge</p>
<br />
<p>On July 23rd, 2013, 9:30 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Inge Wallin.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated July 23, 2013, 9:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Because libcalligrachartshape is no longer shared with anything else that is installed, there is no need to have it as a shared lib with exported symbols.
The only other units using this lib are the tests, and they can just link the lib as a static lib.
So attached patch...
* removes kchart_export.h and all usages of the export macro
* renames libcalligrachartshape to libchartshapecore
* makes the lib static instead of shared
* no longer install it
Result:
+ one lib less installed
+ chart shape loads slightly faster</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Charts still work fine in Sheets (including special controls) and elsewhere.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/chartshape/ARCHITECTURE <span style="color: grey">(028e71a)</span></li>
<li>plugins/chartshape/Axis.h <span style="color: grey">(d24e4aa)</span></li>
<li>plugins/chartshape/CMakeLists.txt <span style="color: grey">(28c71a6)</span></li>
<li>plugins/chartshape/CellRegion.h <span style="color: grey">(6504c15)</span></li>
<li>plugins/chartshape/ChartConfigWidget.h <span style="color: grey">(c0b825d)</span></li>
<li>plugins/chartshape/ChartPart.h <span style="color: grey">(a12a733)</span></li>
<li>plugins/chartshape/ChartProxyModel.h <span style="color: grey">(4abe2ff)</span></li>
<li>plugins/chartshape/ChartShape.h <span style="color: grey">(dedbf5d)</span></li>
<li>plugins/chartshape/ChartTableModel.h <span style="color: grey">(0a09c1f)</span></li>
<li>plugins/chartshape/ChartTool.h <span style="color: grey">(c731542)</span></li>
<li>plugins/chartshape/ChartToolFactory.h <span style="color: grey">(b9d1b49)</span></li>
<li>plugins/chartshape/DataSet.h <span style="color: grey">(71583e7)</span></li>
<li>plugins/chartshape/KDChartModel.h <span style="color: grey">(b1a984d)</span></li>
<li>plugins/chartshape/Legend.h <span style="color: grey">(a733b38)</span></li>
<li>plugins/chartshape/PlotArea.h <span style="color: grey">(6d0064a)</span></li>
<li>plugins/chartshape/TableSource.h <span style="color: grey">(2da46a7)</span></li>
<li>plugins/chartshape/kchart_export.h <span style="color: grey">(b813a64)</span></li>
<li>plugins/chartshape/tests/CMakeLists.txt <span style="color: grey">(98f5c6c)</span></li>
<li>plugins/chartshape/tests/odf/bubble-chart/CMakeLists.txt <span style="color: grey">(6eaa98b)</span></li>
<li>plugins/chartshape/tests/odf/bug239802/CMakeLists.txt <span style="color: grey">(83b8f42)</span></li>
<li>plugins/chartshape/tests/odf/default-calligra-chart/CMakeLists.txt <span style="color: grey">(9f6140b)</span></li>
<li>plugins/chartshape/tests/odf/default-ooo-chart/CMakeLists.txt <span style="color: grey">(57cd5c2)</span></li>
<li>plugins/chartshape/tests/odf/me07_percentage_stacked_bar_chart/CMakeLists.txt <span style="color: grey">(0272951)</span></li>
<li>plugins/chartshape/tests/odf/template/CMakeLists.txt <span style="color: grey">(0adbaf0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111667/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>