Review Request 111329: Do not install Braindump Core's StatesRegistry.h
Commit Hook
null at kde.org
Tue Jul 2 21:14:20 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111329/#review35478
-----------------------------------------------------------
This review has been submitted with commit 0baec4edbc039a27e08afa07f9e4f6300d16c3bb by Friedrich W. H. Kossebau to branch master.
- Commit Hook
On June 30, 2013, 6:43 p.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111329/
> -----------------------------------------------------------
>
> (Updated June 30, 2013, 6:43 p.m.)
>
>
> Review request for Calligra and Cyrille Berger Skott.
>
>
> Description
> -------
>
> I guess other than once planned that header is not yet used outside Calligra. Proof would be that noone complained about the non-installed file braindumpcore_export.h, which is included by StatesRegistry.h :)
>
> Okay to also backport to 2.7?
>
> Or rather also install braindumpcore_export.h (and both to ${INCLUDE_INSTALL_DIR}/braindump)?
>
>
> Diffs
> -----
>
> braindump/braindumpcore/CMakeLists.txt aac6609
>
> Diff: http://git.reviewboard.kde.org/r/111329/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130702/a420ba0c/attachment.htm>
More information about the calligra-devel
mailing list