Review Request 111329: Do not install Braindump Core's StatesRegistry.h

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111329/#review35335
-----------------------------------------------------------

Ship it!


For now at least: don't install it.

- Inge Wallin


On June 30, 2013, 6:43 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111329/
> -----------------------------------------------------------
> 
> (Updated June 30, 2013, 6:43 p.m.)
> 
> 
> Review request for Calligra and Cyrille Berger Skott.
> 
> 
> Description
> -------
> 
> I guess other than once planned that header is not yet used outside Calligra. Proof would be that noone complained about the non-installed file braindumpcore_export.h, which is included by StatesRegistry.h :)
> 
> Okay to also backport to 2.7?
> 
> Or rather also install braindumpcore_export.h (and both to ${INCLUDE_INSTALL_DIR}/braindump)?
> 
> 
> Diffs
> -----
> 
>   braindump/braindumpcore/CMakeLists.txt aac6609 
> 
> Diff: http://git.reviewboard.kde.org/r/111329/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130701/1fd3cfe6/attachment.htm>