Review Request 108588: unoverload KoReportItemBase::render(...)

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108588/#review26336
-----------------------------------------------------------

Ship it!



plugins/reporting/barcode/KoReportItemBarcode.cpp
<http://git.reviewboard.kde.org/r/108588/#comment20080>

    we prefer Q_UNUSED


Good fix, thanks. Also the change to const QVariant &data is nice. Please ix the remaining by-the-way issue and commit.

- Jarosław Staniek


On Jan. 26, 2013, 1:05 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108588/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2013, 1:05 a.m.)
> 
> 
> Review request for Calligra, Adam Pigg and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> Compilers give warning about subclasses of KoReportItemBase which only implement one of the two overloaded virtual render(...) methods, that this way they hide the other.
> 
> Has been partially solved by using "using KoReportItemBase::render;" but obviously not in all places.
> 
> As IMHO there is no real need to have the same method name and thus for overloading, I propose to rename the both methods to
>     void renderSimpleData(...)
>     void renderReportData(...)
> and this way remove the complexity added.
> 
> Attached patch does that and adapts also all usages.
> 
> 
> Diffs
> -----
> 
>   libs/koreport/common/KoReportItemBase.cpp 9fc30c1 
>   libs/koreport/common/KoReportItemBase.h b0669ae 
>   libs/koreport/common/KoReportASyncItemBase.h 0a03c25 
>   libs/koreport/common/KoReportItemLine.h 7a4b324 
>   libs/koreport/common/KoReportItemLine.cpp 58cd8e4 
>   libs/koreport/items/check/KoReportItemCheck.h ec4863c 
>   libs/koreport/items/check/KoReportItemCheck.cpp 1ee64ab 
>   libs/koreport/items/field/KoReportItemField.h 53b2522 
>   libs/koreport/items/field/KoReportItemField.cpp 8945979 
>   libs/koreport/items/image/KoReportItemImage.h 8291a75 
>   libs/koreport/items/image/KoReportItemImage.cpp 28bad77 
>   libs/koreport/items/label/KoReportItemLabel.h 1b56472 
>   libs/koreport/items/label/KoReportItemLabel.cpp ddb5761 
>   libs/koreport/items/text/KoReportItemText.h 2c256e6 
>   libs/koreport/items/text/KoReportItemText.cpp 5e4f530 
>   libs/koreport/renderer/KoReportASyncItemManager.cpp e2b2034 
>   libs/koreport/renderer/KoReportPreRenderer.cpp 4bff685 
>   plugins/reporting/barcode/KoReportItemBarcode.h 6c0b062 
>   plugins/reporting/barcode/KoReportItemBarcode.cpp cf56286 
>   plugins/reporting/chart/KoReportItemChart.h 390545c 
>   plugins/reporting/chart/KoReportItemChart.cpp f5e994b 
>   plugins/reporting/web/KoReportItemWeb.h e007df0 
>   plugins/reporting/web/KoReportItemWeb.cpp 683cb29 
> 
> Diff: http://git.reviewboard.kde.org/r/108588/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130128/e3caebf5/attachment.htm>