<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108588/">http://git.reviewboard.kde.org/r/108588/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108588/diff/1/?file=109255#file109255line178" style="color: black; font-weight: bold; text-decoration: underline;">plugins/reporting/barcode/KoReportItemBarcode.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoReportItemBarcode::setAlignment(int)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">178</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">int</span> <span class="n">KoReportItemBarcode</span><span class="o">::</span><span class="n">render</span><span class="p">(</span><span class="n">OROPage</span><span class="o"><span class="hl">*</span></span><span class="hl"> </span><span class="n">page</span><span class="p">,</span> <span class="n">OROSection</span><span class="o"><span class="hl">*</span></span><span class="hl"> </span><span class="cm">/*section*/</span><span class="p">,</span> <span class="n">QPointF</span> <span class="n">offset</span><span class="p">,</span><span class="hl"> </span><span class="n"><span class="hl">QVariant</span></span><span class="hl"> </span><span class="n"><span class="hl">data</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">KRScriptHandler</span></span><span class="hl"> </span><span class="err"><span class="hl">*/</span></span><span class="o"><span class="hl">*</span></span><span class="n"><span class="hl">script</span></span><span class="err"><span class="hl">*/</span></span><span class="p"><span class="hl">)</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">178</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">int</span> <span class="n">KoReportItemBarcode</span><span class="o">::</span><span class="n">render<span class="hl">SimpleData</span></span><span class="p">(</span><span class="n">OROPage</span> <span class="o"><span class="hl">*</span></span><span class="n">page</span><span class="p">,</span> <span class="n">OROSection</span> <span class="err"><span class="hl">*</span>/</span><span class="o">*</span><span class="n">section</span><span class="err">*/</span><span class="p">,</span> <span class="k"><span class="hl">const</span></span> <span class="n">QPointF</span> <span class="o"><span class="hl">&</span></span><span class="n">offset</span><span class="p">,</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">we prefer Q_UNUSED</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good fix, thanks. Also the change to const QVariant &data is nice. Please ix the remaining by-the-way issue and commit.</pre>
<p>- Jarosław</p>
<br />
<p>On January 26th, 2013, 1:05 a.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Adam Pigg and Jarosław Staniek.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Jan. 26, 2013, 1:05 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compilers give warning about subclasses of KoReportItemBase which only implement one of the two overloaded virtual render(...) methods, that this way they hide the other.
Has been partially solved by using "using KoReportItemBase::render;" but obviously not in all places.
As IMHO there is no real need to have the same method name and thus for overloading, I propose to rename the both methods to
void renderSimpleData(...)
void renderReportData(...)
and this way remove the complexity added.
Attached patch does that and adapts also all usages.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/koreport/common/KoReportItemBase.cpp <span style="color: grey">(9fc30c1)</span></li>
<li>libs/koreport/common/KoReportItemBase.h <span style="color: grey">(b0669ae)</span></li>
<li>libs/koreport/common/KoReportASyncItemBase.h <span style="color: grey">(0a03c25)</span></li>
<li>libs/koreport/common/KoReportItemLine.h <span style="color: grey">(7a4b324)</span></li>
<li>libs/koreport/common/KoReportItemLine.cpp <span style="color: grey">(58cd8e4)</span></li>
<li>libs/koreport/items/check/KoReportItemCheck.h <span style="color: grey">(ec4863c)</span></li>
<li>libs/koreport/items/check/KoReportItemCheck.cpp <span style="color: grey">(1ee64ab)</span></li>
<li>libs/koreport/items/field/KoReportItemField.h <span style="color: grey">(53b2522)</span></li>
<li>libs/koreport/items/field/KoReportItemField.cpp <span style="color: grey">(8945979)</span></li>
<li>libs/koreport/items/image/KoReportItemImage.h <span style="color: grey">(8291a75)</span></li>
<li>libs/koreport/items/image/KoReportItemImage.cpp <span style="color: grey">(28bad77)</span></li>
<li>libs/koreport/items/label/KoReportItemLabel.h <span style="color: grey">(1b56472)</span></li>
<li>libs/koreport/items/label/KoReportItemLabel.cpp <span style="color: grey">(ddb5761)</span></li>
<li>libs/koreport/items/text/KoReportItemText.h <span style="color: grey">(2c256e6)</span></li>
<li>libs/koreport/items/text/KoReportItemText.cpp <span style="color: grey">(5e4f530)</span></li>
<li>libs/koreport/renderer/KoReportASyncItemManager.cpp <span style="color: grey">(e2b2034)</span></li>
<li>libs/koreport/renderer/KoReportPreRenderer.cpp <span style="color: grey">(4bff685)</span></li>
<li>plugins/reporting/barcode/KoReportItemBarcode.h <span style="color: grey">(6c0b062)</span></li>
<li>plugins/reporting/barcode/KoReportItemBarcode.cpp <span style="color: grey">(cf56286)</span></li>
<li>plugins/reporting/chart/KoReportItemChart.h <span style="color: grey">(390545c)</span></li>
<li>plugins/reporting/chart/KoReportItemChart.cpp <span style="color: grey">(f5e994b)</span></li>
<li>plugins/reporting/web/KoReportItemWeb.h <span style="color: grey">(e007df0)</span></li>
<li>plugins/reporting/web/KoReportItemWeb.cpp <span style="color: grey">(683cb29)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108588/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>