Review Request 108481: Temporarily swith to path tool to change shape parameters without double click to switch tool

[Thorsten Zachmann]

> On Jan. 20, 2013, 8:49 a.m., C. Boemann wrote:
> > I have some reservations against this.
> > 
> > In general I think this is the way we should go but I think we should come up with a general solution instead of patchinga single use case
> > 
> > I've been trying to do that grand solution half a year ago, but got sidetracked.
> > 
> > So I would prefer that this does not go in

I agree with boemann here.

Some things I find a bit strange is that when you are over the handles all other handles get removed.

If that is only to solve the double click behaviour I think we can have a different patch that only redefined the double click behaviour for certain applications.


- Thorsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108481/#review25829
-----------------------------------------------------------


On Jan. 19, 2013, 9:11 a.m., Yue Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108481/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2013, 9:11 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> After patch is applied, is a single parameter shape is selected in default tool, parameter handles will be painted. If mouse move on the handles, will temporarily switch to path tool so users can edit shape parameters. In temporary path tool if mouse move off from the handles, current tool will be switched back to default tool.
> 
> Now double click in default tool can be used for other tasks, such as add a new textbox for current shape.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoParameterShape.h 9c0db7a 
>   libs/flake/tools/KoPathTool.h af906bb 
>   libs/flake/tools/KoPathTool.cpp 9dd8caf 
>   libs/flake/tools/KoPathToolFactory.h 2aacfe5 
>   libs/flake/tools/KoPathToolFactory.cpp 1846c86 
>   plugins/defaultTools/defaulttool/DefaultTool.cpp db7c489 
>   plugins/defaultTools/defaulttool/SelectionDecorator.h 83e715e 
>   plugins/defaultTools/defaulttool/SelectionDecorator.cpp 3e16cfa 
> 
> Diff: http://git.reviewboard.kde.org/r/108481/diff/
> 
> 
> Testing
> -------
> 
> works in words, stage, flow, karbon
> 
> 
> Thanks,
> 
> Yue Liu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130122/79a5c60a/attachment.htm>