<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108481/">http://git.reviewboard.kde.org/r/108481/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 20th, 2013, 8:49 a.m. UTC, <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have some reservations against this.
In general I think this is the way we should go but I think we should come up with a general solution instead of patchinga single use case
I've been trying to do that grand solution half a year ago, but got sidetracked.
So I would prefer that this does not go in</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree with boemann here.
Some things I find a bit strange is that when you are over the handles all other handles get removed.
If that is only to solve the double click behaviour I think we can have a different patch that only redefined the double click behaviour for certain applications.</pre>
<br />
<p>- Thorsten</p>
<br />
<p>On January 19th, 2013, 9:11 a.m. UTC, Yue Liu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Yue Liu.</div>
<p style="color: grey;"><i>Updated Jan. 19, 2013, 9:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After patch is applied, is a single parameter shape is selected in default tool, parameter handles will be painted. If mouse move on the handles, will temporarily switch to path tool so users can edit shape parameters. In temporary path tool if mouse move off from the handles, current tool will be switched back to default tool.
Now double click in default tool can be used for other tasks, such as add a new textbox for current shape.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">works in words, stage, flow, karbon</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoParameterShape.h <span style="color: grey">(9c0db7a)</span></li>
<li>libs/flake/tools/KoPathTool.h <span style="color: grey">(af906bb)</span></li>
<li>libs/flake/tools/KoPathTool.cpp <span style="color: grey">(9dd8caf)</span></li>
<li>libs/flake/tools/KoPathToolFactory.h <span style="color: grey">(2aacfe5)</span></li>
<li>libs/flake/tools/KoPathToolFactory.cpp <span style="color: grey">(1846c86)</span></li>
<li>plugins/defaultTools/defaulttool/DefaultTool.cpp <span style="color: grey">(db7c489)</span></li>
<li>plugins/defaultTools/defaulttool/SelectionDecorator.h <span style="color: grey">(83e715e)</span></li>
<li>plugins/defaultTools/defaulttool/SelectionDecorator.cpp <span style="color: grey">(3e16cfa)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108481/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>