Review Request 108479: Change Tracker in KoTextWriter and KoTextLoader removal

[Luke De Mouy]

> On Jan. 19, 2013, 4:01 p.m., C. Boemann wrote:
> > So does it build like this?
> > 
> > I think it's time to put it into a branch - contact me on irc

Yes it builds


> On Jan. 19, 2013, 4:01 p.m., C. Boemann wrote:
> > libs/kotext/opendocument/KoTextWriter_p.cpp, line 1021
> > <http://git.reviewboard.kde.org/r/108479/diff/4/?file=107946#file107946line1021>
> >
> >     where did this come from?

It comes from what was line 1051, I pulled the changeId out so it counts it as something different from closeTagRegion(changeId);


- Luke


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108479/#review25794
-----------------------------------------------------------


On Jan. 19, 2013, 5:03 p.m., Luke De Mouy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108479/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2013, 5:03 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This strips out the change tracking code in KoTextWriter and KoTextLoader, in order to lay the groundwork for a new change tracking system and collaborative editing.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/opendocument/KoTextLoader.h 03856fb 
>   libs/kotext/opendocument/KoTextLoader.cpp d024996 
>   libs/kotext/opendocument/KoTextWriter.h 357d4bc 
>   libs/kotext/opendocument/KoTextWriter.cpp db5f23d 
>   libs/kotext/opendocument/KoTextWriter_p.h f3466e1 
>   libs/kotext/opendocument/KoTextWriter_p.cpp 39cf629 
> 
> Diff: http://git.reviewboard.kde.org/r/108479/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luke De Mouy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130119/4df8ff6e/attachment.htm>