Review Request 108479: Change Tracker in KoTextWriter and KoTextLoader removal

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108479/#review25794
-----------------------------------------------------------


So does it build like this?

I think it's time to put it into a branch - contact me on irc


libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19708>

    this can go



libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19709>

    these two can go



libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19707>

    this class can go



libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19710>

    but then this if can changed to != so we don't have an empty block



libs/kotext/opendocument/KoTextWriter_p.cpp
<http://git.reviewboard.kde.org/r/108479/#comment19711>

    where did this come from?


- C. Boemann


On Jan. 19, 2013, 8:34 a.m., Luke De Mouy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108479/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2013, 8:34 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This strips out the change tracking code in KoTextWriter and KoTextLoader, in order to lay the groundwork for a new change tracking system and collaborative editing.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/opendocument/KoTextLoader.h 03856fb 
>   libs/kotext/opendocument/KoTextLoader.cpp d024996 
>   libs/kotext/opendocument/KoTextWriter.h 357d4bc 
>   libs/kotext/opendocument/KoTextWriter.cpp db5f23d 
>   libs/kotext/opendocument/KoTextWriter_p.h f3466e1 
>   libs/kotext/opendocument/KoTextWriter_p.cpp 39cf629 
> 
> Diff: http://git.reviewboard.kde.org/r/108479/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luke De Mouy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130119/b930457e/attachment.htm>