Review Request 108475: fix broken check for small diff in KoTextLayoutArea::layoutBlock(...)

C. Boemann cbr at boemann.dk
Sat Jan 19 00:39:42 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108475/#review25767
-----------------------------------------------------------

Ship it!


yes you are right - good catch and please backport too

- C. Boemann


On Jan. 18, 2013, 6:53 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108475/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2013, 6:53 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> MS compiler complained about this strange check. And I think rightly so.
> 
> Attached patch makes more sense to me. Not sure what its effect is. Just the logic seem better to me. You may be able to tell, though, your commit :)
> 
> Okay to also backport to 2.6?
> 
> 
> Diffs
> -----
> 
>   libs/textlayout/KoTextLayoutArea.cpp a503f81 
> 
> Diff: http://git.reviewboard.kde.org/r/108475/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130119/92910d9b/attachment.htm>


More information about the calligra-devel mailing list