Review Request 108475: fix broken check for small diff in KoTextLayoutArea::layoutBlock(...)
Jarosław Staniek
staniek at kde.org
Fri Jan 18 20:48:59 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108475/#review25762
-----------------------------------------------------------
Ship it!
Another case when supporting MSVC improves code quality :)
- Jarosław Staniek
On Jan. 18, 2013, 6:53 p.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108475/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2013, 6:53 p.m.)
>
>
> Review request for Calligra and C. Boemann.
>
>
> Description
> -------
>
> MS compiler complained about this strange check. And I think rightly so.
>
> Attached patch makes more sense to me. Not sure what its effect is. Just the logic seem better to me. You may be able to tell, though, your commit :)
>
> Okay to also backport to 2.6?
>
>
> Diffs
> -----
>
> libs/textlayout/KoTextLayoutArea.cpp a503f81
>
> Diff: http://git.reviewboard.kde.org/r/108475/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130118/8d65ae91/attachment.htm>
More information about the calligra-devel
mailing list