Review Request 108424: updated modebox for words,sheets,author

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108424/#review25631
-----------------------------------------------------------

Ship it!


I like this a lot because it leaves the full vertical space available for the tools. I am using a smaller screen than most people so I suffer from the vertical bagage of the previous toolbox. However, I'm not 100% enamoured yet. The buttons take up a little too much room and the text in them is super small and difficult to read if you don't have very good eyesight. 

In general I think the idea is well enough implemented to warrant an inclusion now and I also think the new way is better than the old one. But I don't think we're done with fine tuning our UI in this area just yet.


libs/main/KoModeBox.cpp
<http://git.reviewboard.kde.org/r/108424/#comment19544>

    I think it would make sense to create a function for this.


- Inge Wallin


On Jan. 15, 2013, 12:34 p.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108424/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2013, 12:34 p.m.)
> 
> 
> Review request for Calligra, Inge Wallin, Marijn Kruisselbrink, and Thorsten Zachmann.
> 
> 
> Description
> -------
> 
> I've changed the modebox away from using qtoolbox to a tab bar and stacked widget
> 
> In the future i hope stage can use this too so that is why i include Thorsten specfically too.
> 
> 
> Diffs
> -----
> 
>   libs/main/KoModeBox.cpp 8b49f6e 
>   libs/main/KoModeBox_p.h c437757 
> 
> Diff: http://git.reviewboard.kde.org/r/108424/diff/
> 
> 
> Testing
> -------
> 
> played with it, without problems
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130116/26fff875/attachment.htm>