<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108424/">http://git.reviewboard.kde.org/r/108424/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I like this a lot because it leaves the full vertical space available for the tools. I am using a smaller screen than most people so I suffer from the vertical bagage of the previous toolbox. However, I'm not 100% enamoured yet. The buttons take up a little too much room and the text in them is super small and difficult to read if you don't have very good eyesight.
In general I think the idea is well enough implemented to warrant an inclusion now and I also think the new way is better than the old one. But I don't think we're done with fine tuning our UI in this area just yet.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108424/diff/1/?file=107370#file107370line188" style="color: black; font-weight: bold; text-decoration: underline;">libs/main/KoModeBox.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoModeBox::addItem(const KoToolButton button)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">165</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QToolBox</span><span class="o">::</span><span class="n">addItem</span><span class="p">(</span><span class="n">widget</span><span class="p">,</span> <span class="n">button</span><span class="p">.</span><span class="n">button</span><span class="o">-></span><span class="n">icon</span><span class="p">(),</span> <span class="n">button</span><span class="p">.</span><span class="n">button</span><span class="o">-></span><span class="n">toolTip</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">187</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// Create a rotated icon with text</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think it would make sense to create a function for this.</pre>
</div>
<br />
<p>- Inge</p>
<br />
<p>On January 15th, 2013, 12:34 p.m. UTC, C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Inge Wallin, Marijn Kruisselbrink, and Thorsten Zachmann.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated Jan. 15, 2013, 12:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've changed the modebox away from using qtoolbox to a tab bar and stacked widget
In the future i hope stage can use this too so that is why i include Thorsten specfically too.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">played with it, without problems</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/main/KoModeBox.cpp <span style="color: grey">(8b49f6e)</span></li>
<li>libs/main/KoModeBox_p.h <span style="color: grey">(c437757)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108424/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>