Review Request 108358: shape placement restrictions in Words

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108358/
-----------------------------------------------------------

(Updated Jan. 12, 2013, 4:19 p.m.)


Review request for Calligra and Thorsten Zachmann.


Changes
-------

I've fixed it so loading documents where the shapes are on pages after page 1 also works. Not a bad idea, eh ;)

I've also fixed so page anchored shape doesnt spoil the text layout with big empty rectangles on page 1


Description
-------

    Shape moving restrictions based on anchor properties.
    
    This is the page anchors equivalent of the char and paragraph anchors code we
    already have.
    
    This makes a difference both on initial layout (nice improvements)
    and on interactive moving of page anchored shapes.


Diffs (updated)
-----

  libs/kotext/KoTextAnchor.cpp 6783bdc 
  plugins/defaultTools/defaulttool/ShapeMoveStrategy.h e2d26c2 
  plugins/defaultTools/defaulttool/ShapeMoveStrategy.cpp 4ebfb57 
  words/part/KWCanvasBase.cpp 5592e1d 
  words/part/KWRootAreaProvider.cpp a52c29e 
  words/part/frames/KWFrameLayout.h a7408b7 
  words/part/frames/KWFrameLayout.cpp 4e389ff 

Diff: http://git.reviewboard.kde.org/r/108358/diff/


Testing
-------

I have a simple test document created in LO that now loads correctly (was very bad before)

I've also played around with the interactive restrictions and they seem to work as well.

But a cstester run is needed


Thanks,

C. Boemann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130112/4c8046b2/attachment.htm>