<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108358/">http://git.reviewboard.kde.org/r/108358/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Thorsten Zachmann.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated Jan. 12, 2013, 4:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've fixed it so loading documents where the shapes are on pages after page 1 also works. Not a bad idea, eh ;)
I've also fixed so page anchored shape doesnt spoil the text layout with big empty rectangles on page 1</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Shape moving restrictions based on anchor properties.
This is the page anchors equivalent of the char and paragraph anchors code we
already have.
This makes a difference both on initial layout (nice improvements)
and on interactive moving of page anchored shapes.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have a simple test document created in LO that now loads correctly (was very bad before)
I've also played around with the interactive restrictions and they seem to work as well.
But a cstester run is needed</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/KoTextAnchor.cpp <span style="color: grey">(6783bdc)</span></li>
<li>plugins/defaultTools/defaulttool/ShapeMoveStrategy.h <span style="color: grey">(e2d26c2)</span></li>
<li>plugins/defaultTools/defaulttool/ShapeMoveStrategy.cpp <span style="color: grey">(4ebfb57)</span></li>
<li>words/part/KWCanvasBase.cpp <span style="color: grey">(5592e1d)</span></li>
<li>words/part/KWRootAreaProvider.cpp <span style="color: grey">(a52c29e)</span></li>
<li>words/part/frames/KWFrameLayout.h <span style="color: grey">(a7408b7)</span></li>
<li>words/part/frames/KWFrameLayout.cpp <span style="color: grey">(4e389ff)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108358/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>