Review Request: Fix crash on empty style list in StyleManager dialog

Pierre Stirnweiss pstirnweiss at googlemail.com
Fri Jan 11 19:08:48 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108353/
-----------------------------------------------------------

Review request for Calligra, C. Boemann and Friedrich W. H. Kossebau.


Description
-------

On an empty style list, the style manager dialog would pass around null styles (for preview,...). Add some test for null styles in some places solves the crash. I will work on a new dialog in the very near future, so even if the solution is not ideal (a big blank tab), it is the best we can do for 2.6.


This addresses bug 313031.
    http://bugs.kde.org/show_bug.cgi?id=313031


Diffs
-----

  plugins/textshape/dialogs/FormattingPreview.cpp 1ed3b83 
  plugins/textshape/dialogs/StyleManager.cpp c561d35 

Diff: http://git.reviewboard.kde.org/r/108353/diff/


Testing
-------


Thanks,

Pierre Stirnweiss

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130111/f39eb50b/attachment.htm>


More information about the calligra-devel mailing list