Review Request: Setting working environment on launching in Windows

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108295/#review25074
-----------------------------------------------------------



flow/part/main.cpp
<http://git.reviewboard.kde.org/r/108295/#comment19181>

    I think proper place for this code is KoApplication::start(). This way the code can be nicely shared and the main.cpp files can be kept unmodified. I would also like to have this code in Kexi but I can adapt to it on my own after you commit.



flow/part/main.cpp
<http://git.reviewboard.kde.org/r/108295/#comment19182>

    - can we use qputenv() everywhere for convention (could be more mingw-compatible perhaps for free)?
    - convention says: let's use QFile::encodeName() everywhere to properly convert paths from unicode to local 8-bit


- Jarosław Staniek


On Jan. 9, 2013, 3:27 p.m., Stuart Dickson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108295/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2013, 3:27 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> In order to allow Calligra applications to be run as pre-built binaries on Windows operating system, some environment variables need to be set in order to allow plugins etc to be correctly found.
> 
> Previously, the packaged version of the applications used a combination of batch file and VBS script in order to set the environment invisibly to the user before launching the application.
> 
> The patch allows the Calligra binaries (words, sheets, stage, karbon, plan, flow) to be launched directly.
> This also resolves occasional issues where scripting was not correctly installed, or was not available to the user.
> It also makes possible associating the Calligra applications against document file types.
> 
> 
> Diffs
> -----
> 
>   flow/part/main.cpp 67d1926 
>   karbon/main.cpp 4e90edb 
>   plan/main.cpp 96f0b7a 
>   sheets/part/Main.cpp facda77 
>   stage/part/main.cpp 5ef9509 
>   words/part/main.cpp 875eb5d 
> 
> Diff: http://git.reviewboard.kde.org/r/108295/diff/
> 
> 
> Testing
> -------
> 
> Built and run on Windows system, demonstrated to work with existing packaging setup.
> Modifications are wrapped in an OS-centric block (with the exception of the additional headers required), so this willl not affect Linux builds.
> 
> 
> Thanks,
> 
> Stuart Dickson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130109/5cab02b3/attachment.htm>