<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108295/">http://git.reviewboard.kde.org/r/108295/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108295/diff/1/?file=106136#file106136line40" style="color: black; font-weight: bold; text-decoration: underline;">flow/part/main.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">40</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QDir</span> <span class="n">appdir</span><span class="p">(</span><span class="n">app</span><span class="p">.</span><span class="n">applicationDirPath</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think proper place for this code is KoApplication::start(). This way the code can be nicely shared and the main.cpp files can be kept unmodified. I would also like to have this code in Kexi but I can adapt to it on my own after you commit.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108295/diff/1/?file=106136#file106136line48" style="color: black; font-weight: bold; text-decoration: underline;">flow/part/main.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">48</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">_putenv_s</span><span class="p">(</span><span class="s">"KDEHOME"</span><span class="p">,</span> <span class="n">QDesktopServices</span><span class="o">::</span><span class="n">storageLocation</span><span class="p">(</span><span class="n">QDesktopServices</span><span class="o">::</span><span class="n">DataLocation</span><span class="p">).</span><span class="n">toLocal8Bit</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- can we use qputenv() everywhere for convention (could be more mingw-compatible perhaps for free)?
- convention says: let's use QFile::encodeName() everywhere to properly convert paths from unicode to local 8-bit</pre>
</div>
<br />
<p>- Jarosław</p>
<br />
<p>On January 9th, 2013, 3:27 p.m., Stuart Dickson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Stuart Dickson.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2013, 3:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In order to allow Calligra applications to be run as pre-built binaries on Windows operating system, some environment variables need to be set in order to allow plugins etc to be correctly found.
Previously, the packaged version of the applications used a combination of batch file and VBS script in order to set the environment invisibly to the user before launching the application.
The patch allows the Calligra binaries (words, sheets, stage, karbon, plan, flow) to be launched directly.
This also resolves occasional issues where scripting was not correctly installed, or was not available to the user.
It also makes possible associating the Calligra applications against document file types.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built and run on Windows system, demonstrated to work with existing packaging setup.
Modifications are wrapped in an OS-centric block (with the exception of the additional headers required), so this willl not affect Linux builds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>flow/part/main.cpp <span style="color: grey">(67d1926)</span></li>
<li>karbon/main.cpp <span style="color: grey">(4e90edb)</span></li>
<li>plan/main.cpp <span style="color: grey">(96f0b7a)</span></li>
<li>sheets/part/Main.cpp <span style="color: grey">(facda77)</span></li>
<li>stage/part/main.cpp <span style="color: grey">(5ef9509)</span></li>
<li>words/part/main.cpp <span style="color: grey">(875eb5d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108295/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>