Review Request 108231: in Kpr import filter store all automatic styles from the master page in styles.xml
Commit Hook
null at kde.org
Thu Feb 28 19:13:12 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108231/#review28286
-----------------------------------------------------------
This review has been submitted with commit e8e0e8a51acc9c2edcbc432502642b69a95b2ec6 by Friedrich W. H. Kossebau to branch master.
- Commit Hook
On Jan. 6, 2013, 8:04 p.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108231/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2013, 8:04 p.m.)
>
>
> Review request for Calligra and Thorsten Zachmann.
>
>
> Description
> -------
>
> I found an old kpr file where the header and footer text styles were not correctly imported.
> Reason was that the related generated automatic styles are stored in content.xml, not styles.xml, so they are not seen on loading the created .odp file.
>
> Attached patch fixes that by calling for all generated automatic styles setAutoStyleInStylesDotXml() with that m_sticky flag, which tells if the object is part of the master page.
>
> Okay to backport to 2.6?
>
>
> Diffs
> -----
>
> filters/stage/kpr2odf/StylesFilterkpr2odf.cpp fc14030
>
> Diff: http://git.reviewboard.kde.org/r/108231/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130228/59fac5f4/attachment.htm>
More information about the calligra-devel
mailing list