Review Request 108231: in Kpr import filter store all automatic styles from the master page in styles.xml

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108231/#review28095
-----------------------------------------------------------

Ship it!


Looks good. This must have slipped me. Sorry about that. Friedrich is it possible that you provide the file for inclusion in the test documents?

- Thorsten Zachmann


On Jan. 6, 2013, 8:04 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108231/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2013, 8:04 p.m.)
> 
> 
> Review request for Calligra and Thorsten Zachmann.
> 
> 
> Description
> -------
> 
> I found an old kpr file where the header and footer text styles were not correctly imported.
> Reason was that the related generated automatic styles are stored in content.xml, not styles.xml, so they are not seen on loading the created .odp file.
> 
> Attached patch fixes that by calling for all generated automatic styles setAutoStyleInStylesDotXml() with that m_sticky flag, which tells if the object is part of the master page.
> 
> Okay to backport to 2.6?
> 
> 
> Diffs
> -----
> 
>   filters/stage/kpr2odf/StylesFilterkpr2odf.cpp fc14030 
> 
> Diff: http://git.reviewboard.kde.org/r/108231/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130226/9b45669f/attachment.htm>