Review Request 108781: Moving Formatting in Calligrawords from old framework to new framework.

Sudhendu Kumar sudhendu.kumar.roy at gmail.com
Thu Feb 28 17:40:22 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108781/
-----------------------------------------------------------

(Updated Feb. 28, 2013, 5:40 p.m.)


Review request for Calligra and C. Boemann.


Changes
-------

Improved the mergeAutoStyle code as per setStyle.
Still had to use mergeCharFormat instead of setCharFormat.
setCharFormat didn't allow to apply formatting without selection.
Also added strikeout in new framework.

Tested various scenarios. Works fine.


Description
-------

Moving formatting from old framework to new framework. This patch only contains for bold. Once this is approved, same can be done for other formattings as well.


Diffs (updated)
-----

  libs/kotext/KoTextEditor_format.cpp 5a35fe8 
  libs/kotext/KoTextEditor_undo.cpp 8dba444 

Diff: http://git.reviewboard.kde.org/r/108781/diff/


Testing
-------

Works well for me.


Thanks,

Sudhendu Kumar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130228/05974930/attachment.htm>


More information about the calligra-devel mailing list