Review Request 108781: Moving Formatting in Calligrawords from old framework to new framework.

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108781/#review27224
-----------------------------------------------------------



libs/kotext/KoTextEditor_format.cpp
<http://git.reviewboard.kde.org/r/108781/#comment20499>

    please see the much more elaborate code KoTextEditor::setStyle(KoCharacterStyle
    
    
    you aproach is too simplistic. You need to more or less copy the 10 or so lines of code I referred to



libs/kotext/KoTextEditor_undo.cpp
<http://git.reviewboard.kde.org/r/108781/#comment20498>

    oops i don't think you mean to change this 


- C. Boemann


On Feb. 11, 2013, 6:52 p.m., Sudhendu Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108781/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2013, 6:52 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> Moving formatting from old framework to new framework. This patch only contains for bold. Once this is approved, same can be done for other formattings as well.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoTextEditor_format.cpp 5a35fe8 
>   libs/kotext/KoTextEditor_undo.cpp 8dba444 
> 
> Diff: http://git.reviewboard.kde.org/r/108781/diff/
> 
> 
> Testing
> -------
> 
> Works well for me.
> 
> 
> Thanks,
> 
> Sudhendu Kumar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130211/8aa35660/attachment.htm>