Review Request 109046: Normalize SIGNAL and SLOT signatures in the top level directory of Plan

Inge Wallin inge at lysator.liu.se
Tue Feb 26 17:22:03 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109046/
-----------------------------------------------------------

(Updated Feb. 26, 2013, 5:22 p.m.)


Review request for Calligra and Dag Andersen.


Changes
-------

Updated patch after I updated the normalizer in fixsrc.py.  There is one difference from before, where a Foo& was erroneously changed to Foo, which is now fixed.


Description
-------

This is yet another normalize signature patch created by fixsrc.py, this time in Plan.

According to http://englishbreakfastnetwork.org/krazy/reports/bundled-apps/calligra/plan/index.html there are over 2000 such issues in Plan so I'm only fixing those at the top level so that they can be inspected manually without choking on the sheer amount.


Diffs (updated)
-----

  plan/kptviewlistdocker.cpp 2c5ec18 
  plan/kptviewlistdialog.cpp bd7c805 
  plan/kptview.cpp fcfa192 
  plan/kptviewlist.cpp 86a3c93 
  plan/kpttaskdefaultpanel.cpp ec15644 
  plan/kptpart.cpp 1657c06 
  plan/kptschedulesdocker.cpp 3217f77 
  plan/kptinsertfiledlg.cpp 045bce1 
  plan/kptmaindocument.cpp b4afbc3 
  plan/kptbuiltinschedulerplugin.cpp c29ae4c 

Diff: http://git.reviewboard.kde.org/r/109046/diff/


Testing
-------


Thanks,

Inge Wallin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130226/28b5357d/attachment.htm>


More information about the calligra-devel mailing list