Review Request 109088: remove code variants for Qt versions below the current min.requ. 4.7.0

[Friedrich W. H. Kossebau]

> On Feb. 21, 2013, 10:07 p.m., C. Boemann wrote:
> > Ship It!
> 
> Boudewijn Rempt wrote:
>     Well, no, please don't ship it. I need to be able to make packages for CentOS 6 still :-(

Yes, seen the requirement with CentOS 6 being Qt 4.6 only. Given that this is a serious usecase, IMHO we should support that. Possibly also means we need to redo the KDE min require bump and the according code clean-up.
Still I think we should only revert the min requ. for the parts that Krita really needs to be useful, like related stuff in libs and some plugins, and krita/ of course. Rest of Calligra codebase should continue with the current min. requirements (and according cleanup).

So will update this patch to cleanup only code outside of Krita needs.


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109088/#review27872
-----------------------------------------------------------


On Feb. 21, 2013, 9:58 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109088/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2013, 9:58 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Came across some code for Qt <4.7.0 and found there are more code path which can go to code nirvana.
> 
> Should be safe, but it is late, so better have somebody okay it.
> 
> 
> Diffs
> -----
> 
>   words/part/KWCanvasItem.cpp e2122bd 
>   libs/textlayout/KoTextShapeContainerModel.cpp 51d9da5 
>   plan/libs/kernel/kptdatetime.cpp 39974f5 
>   plan/libs/kernel/tests/DateTimeTester.h a1ca9e7 
>   plan/libs/kernel/tests/DateTimeTester.cpp 9365940 
>   plan/libs/ui/kptdependencyeditor.cpp 3f76c36 
>   sheets/Region.cpp e5596b4 
>   stage/part/KPrShapeAnimations.cpp 850c41e 
>   stage/part/tools/animationtool/KPrTimeLineView.cpp c781fe4 
>   flow/plugins/dockers/stencilboxdocker/StencilBoxDocker.cpp 96aacbf 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.h d91f2a6 
>   krita/plugins/extensions/dockers/compositiondocker/compositiondocker_dock.cpp 305fb9b 
>   krita/plugins/paintops/curvebrush/curve_brush.cpp 23d6eda 
>   krita/ui/input/kis_input_manager.cpp 5b159d6 
>   libs/kopageapp/KoPACanvasItem.cpp 166867a 
>   libs/koreport/wrtembed/KoReportDesignerItemLine.cpp f4f4a1f 
>   libs/koreport/wrtembed/KoReportDesignerItemRectBase.cpp 53c3727 
>   libs/pigment/KoCompositeOpRegistry.cpp ed23d9a 
> 
> Diff: http://git.reviewboard.kde.org/r/109088/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130222/e2960659/attachment.htm>