<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109088/">http://git.reviewboard.kde.org/r/109088/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 21st, 2013, 10:07 p.m. UTC, <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
<p>On February 22nd, 2013, 8:51 a.m. UTC, <b>Boudewijn Rempt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, no, please don't ship it. I need to be able to make packages for CentOS 6 still :-(</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, seen the requirement with CentOS 6 being Qt 4.6 only. Given that this is a serious usecase, IMHO we should support that. Possibly also means we need to redo the KDE min require bump and the according code clean-up.
Still I think we should only revert the min requ. for the parts that Krita really needs to be useful, like related stuff in libs and some plugins, and krita/ of course. Rest of Calligra codebase should continue with the current min. requirements (and according cleanup).
So will update this patch to cleanup only code outside of Krita needs.</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On February 21st, 2013, 9:58 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Feb. 21, 2013, 9:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Came across some code for Qt <4.7.0 and found there are more code path which can go to code nirvana.
Should be safe, but it is late, so better have somebody okay it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>words/part/KWCanvasItem.cpp <span style="color: grey">(e2122bd)</span></li>
<li>libs/textlayout/KoTextShapeContainerModel.cpp <span style="color: grey">(51d9da5)</span></li>
<li>plan/libs/kernel/kptdatetime.cpp <span style="color: grey">(39974f5)</span></li>
<li>plan/libs/kernel/tests/DateTimeTester.h <span style="color: grey">(a1ca9e7)</span></li>
<li>plan/libs/kernel/tests/DateTimeTester.cpp <span style="color: grey">(9365940)</span></li>
<li>plan/libs/ui/kptdependencyeditor.cpp <span style="color: grey">(3f76c36)</span></li>
<li>sheets/Region.cpp <span style="color: grey">(e5596b4)</span></li>
<li>stage/part/KPrShapeAnimations.cpp <span style="color: grey">(850c41e)</span></li>
<li>stage/part/tools/animationtool/KPrTimeLineView.cpp <span style="color: grey">(c781fe4)</span></li>
<li>flow/plugins/dockers/stencilboxdocker/StencilBoxDocker.cpp <span style="color: grey">(96aacbf)</span></li>
<li>kexi/plugins/importexport/csv/kexicsvimportdialog.h <span style="color: grey">(d91f2a6)</span></li>
<li>krita/plugins/extensions/dockers/compositiondocker/compositiondocker_dock.cpp <span style="color: grey">(305fb9b)</span></li>
<li>krita/plugins/paintops/curvebrush/curve_brush.cpp <span style="color: grey">(23d6eda)</span></li>
<li>krita/ui/input/kis_input_manager.cpp <span style="color: grey">(5b159d6)</span></li>
<li>libs/kopageapp/KoPACanvasItem.cpp <span style="color: grey">(166867a)</span></li>
<li>libs/koreport/wrtembed/KoReportDesignerItemLine.cpp <span style="color: grey">(f4f4a1f)</span></li>
<li>libs/koreport/wrtembed/KoReportDesignerItemRectBase.cpp <span style="color: grey">(53c3727)</span></li>
<li>libs/pigment/KoCompositeOpRegistry.cpp <span style="color: grey">(ed23d9a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109088/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>