Review Request 109071: Add a PRODUCTSET build config parameter (values ACTIVE, CREATIVE, DESKTOP, ALL)

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109071/#review27811
-----------------------------------------------------------


Really nice cleanup! Here are some remarks.


CMakeLists.txt
<http://git.reviewboard.kde.org/r/109071/#comment20849>

    Not only code: CREATIVEONY is used in many scripts for compiling Krita provided by 3rd parties, like David Revoy, it's in Portfiles for MacPorts, in emerge settings. I think we need a compatibility setting at least until 2.9



CMakeLists.txt
<http://git.reviewboard.kde.org/r/109071/#comment20850>

    Okular is in Plasma Active, so I'd say, yes.



filters/sheets/CMakeLists.txt
<http://git.reviewboard.kde.org/r/109071/#comment20851>

    Hm, this is tricky. These filters for more or less obsolete formats were disabled in TINY because there was no space on mobile devices for them, and very little need. Maybe we need something extra to prune the set of filters?
    
    Something like was done for the plugins?



plugins/CMakeLists.txt
<http://git.reviewboard.kde.org/r/109071/#comment20852>

    pictureshape is not relevant for Karbon either.



stage/app/CMakeLists.txt
<http://git.reviewboard.kde.org/r/109071/#comment20853>

    Wouldn't it be better to have the moving of stuff to app directories in a separate patch, or at least commit?


- Boudewijn Rempt


On Feb. 21, 2013, 1:55 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109071/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2013, 1:55 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> PRODUCTSET is a substitute for the old non-exclusive options CREATIVEONLY and TINY (which then are handled exclusively, eek), with migration support for CREATIVEONLY flag. Predefined hardcoded productsets are ACTIVE, CREATIVE, DESKTOP, and ALL (as fallback and default).
>     
> Patch also turns buildsystem to have a SHOULD_BUILD for each product (app/plugin), which then all get turned on centrally in groups depending on the productset, instead of everywhere having overlapping and hard to oversee if-else blocks deciding what gets build and what not.
> 
> Not the perfect final solution, but a first step into the right direction IMHO.
> 
> Known issues:
> * BUILD_AUTHOR is not yet set
> 
> Patch can be also tested as branch addProductSetBuildParameter-kossebau.
> 
> 
> Diffs
> -----
> 
>   words/part/CMakeLists.txt 56b8c6f 
>   words/part/Info.plist.template 97e1728 
>   words/part/main.cpp 875eb5d 
>   words/part/words.desktop 35bc4c3 
>   words/app/main.cpp PRE-CREATION 
>   words/app/words.desktop PRE-CREATION 
>   words/app/CMakeLists.txt PRE-CREATION 
>   words/app/Info.plist.template PRE-CREATION 
>   stage/part/Info.plist.template 857a8d7 
>   stage/part/main.cpp 5ef9509 
>   stage/part/stage.desktop 447858f 
>   tools/CMakeLists.txt eefe95b 
>   words/CMakeLists.txt e6336a2 
>   3rdparty/CMakeLists.txt a300bd2 
>   CMakeLists.txt d9945a1 
>   filters/CMakeLists.txt 5acecef 
>   filters/sheets/CMakeLists.txt 351a8e2 
>   filters/words/CMakeLists.txt 0c2107c 
>   libs/CMakeLists.txt 2036cf5 
>   plugins/CMakeLists.txt 0e87b1e 
>   sheets/CMakeLists.txt 9f96e41 
>   stage/CMakeLists.txt 94dd31c 
>   stage/app/CMakeLists.txt PRE-CREATION 
>   stage/app/Info.plist.template PRE-CREATION 
>   stage/app/main.cpp PRE-CREATION 
>   stage/app/stage.desktop PRE-CREATION 
>   stage/part/CMakeLists.txt de57a0f 
> 
> Diff: http://git.reviewboard.kde.org/r/109071/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130221/18959aa2/attachment.htm>