<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109071/">http://git.reviewboard.kde.org/r/109071/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Really nice cleanup! Here are some remarks.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109071/diff/1/?file=114664#file114664line46" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">46</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">IF</span> <span class="p">(</span><span class="s">TINY</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">46</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"># </span><span class="cs">TODO</span><span class="c">: remove option and migration code below before 2.7 release</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not only code: CREATIVEONY is used in many scripts for compiling Krita provided by 3rd parties, like David Revoy, it's in Portfiles for MacPorts, in emerge settings. I think we need a compatibility setting at least until 2.9</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109071/diff/1/?file=114664#file114664line99" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">66</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">set</span><span class="p">(</span><span class="s">SHOULD_BUILD_SHEETS</span> <span class="s">FALSE</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">99</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"># set(SHOULD_BUILD_OKULARODPGENERATOR TRUE) </span><span class="cs">TODO</span><span class="c">: wanted here or not?</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Okular is in Plasma Active, so I'd say, yes.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109071/diff/1/?file=114666#file114666line5" style="color: black; font-weight: bold; text-decoration: underline;">filters/sheets/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">5</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">if</span><span class="p">(</span><span class="s">NOT</span> <span class="s">TINY</span><span class="p">)</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm, this is tricky. These filters for more or less obsolete formats were disabled in TINY because there was no space on mobile devices for them, and very little need. Maybe we need something extra to prune the set of filters?
Something like was done for the plugins?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109071/diff/1/?file=114669#file114669line53" style="color: black; font-weight: bold; text-decoration: underline;">plugins/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">53</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"># set(SHOULD_BUILD_PLUGIN_PICTURESHAPE TRUE) </span><span class="cs">TODO</span><span class="c">: what about karbon?</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">pictureshape is not relevant for Karbon either.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109071/diff/1/?file=114672#file114672line1" style="color: black; font-weight: bold; text-decoration: underline;">stage/app/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">project</span><span class="p">(</span><span class="s">stageapp</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wouldn't it be better to have the moving of stuff to app directories in a separate patch, or at least commit?</pre>
</div>
<br />
<p>- Boudewijn</p>
<br />
<p>On February 21st, 2013, 1:55 a.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Feb. 21, 2013, 1:55 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">PRODUCTSET is a substitute for the old non-exclusive options CREATIVEONLY and TINY (which then are handled exclusively, eek), with migration support for CREATIVEONLY flag. Predefined hardcoded productsets are ACTIVE, CREATIVE, DESKTOP, and ALL (as fallback and default).
Patch also turns buildsystem to have a SHOULD_BUILD for each product (app/plugin), which then all get turned on centrally in groups depending on the productset, instead of everywhere having overlapping and hard to oversee if-else blocks deciding what gets build and what not.
Not the perfect final solution, but a first step into the right direction IMHO.
Known issues:
* BUILD_AUTHOR is not yet set
Patch can be also tested as branch addProductSetBuildParameter-kossebau.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>words/part/CMakeLists.txt <span style="color: grey">(56b8c6f)</span></li>
<li>words/part/Info.plist.template <span style="color: grey">(97e1728)</span></li>
<li>words/part/main.cpp <span style="color: grey">(875eb5d)</span></li>
<li>words/part/words.desktop <span style="color: grey">(35bc4c3)</span></li>
<li>words/app/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/app/words.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/app/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/app/Info.plist.template <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/Info.plist.template <span style="color: grey">(857a8d7)</span></li>
<li>stage/part/main.cpp <span style="color: grey">(5ef9509)</span></li>
<li>stage/part/stage.desktop <span style="color: grey">(447858f)</span></li>
<li>tools/CMakeLists.txt <span style="color: grey">(eefe95b)</span></li>
<li>words/CMakeLists.txt <span style="color: grey">(e6336a2)</span></li>
<li>3rdparty/CMakeLists.txt <span style="color: grey">(a300bd2)</span></li>
<li>CMakeLists.txt <span style="color: grey">(d9945a1)</span></li>
<li>filters/CMakeLists.txt <span style="color: grey">(5acecef)</span></li>
<li>filters/sheets/CMakeLists.txt <span style="color: grey">(351a8e2)</span></li>
<li>filters/words/CMakeLists.txt <span style="color: grey">(0c2107c)</span></li>
<li>libs/CMakeLists.txt <span style="color: grey">(2036cf5)</span></li>
<li>plugins/CMakeLists.txt <span style="color: grey">(0e87b1e)</span></li>
<li>sheets/CMakeLists.txt <span style="color: grey">(9f96e41)</span></li>
<li>stage/CMakeLists.txt <span style="color: grey">(94dd31c)</span></li>
<li>stage/app/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/app/Info.plist.template <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/app/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/app/stage.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/CMakeLists.txt <span style="color: grey">(de57a0f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109071/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>