Review Request 109057: Normalize SIGNAL and SLOT signatures in kexi

Inge Wallin inge at lysator.liu.se
Wed Feb 20 17:33:50 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109057/
-----------------------------------------------------------

Review request for Calligra and Jarosław Staniek.


Description
-------

This patch does signature normalization for SIGNAL and SLOT macros in kexi.

I did it after Jaroslaw asked me, otherwise I would have waited until after the similar patch for Plan was either ok'ed or denied.


Diffs
-----

  kexi/widget/tableview/kexitableview.cpp 6f3559f 
  kexi/widget/tableview/kexitableviewheader.cpp 3405bbe 
  kexi/widget/relations/KexiRelationsTableContainer_p.cpp bf0ebe5 
  kexi/widget/relations/KexiRelationsView.cpp 6e47811 
  kexi/widget/tableview/kexiblobtableedit.cpp 286d068 
  kexi/widget/tableview/kexicomboboxbase.cpp 7a15e48 
  kexi/widget/tableview/kexicomboboxpopup.cpp 6239a88 
  kexi/widget/tableview/kexicomboboxtableedit.cpp 0279280 
  kexi/widget/tableview/kexidatatableview.cpp 93da5b6 
  kexi/widget/tableview/kexiinputtableedit.cpp d75e3d5 
  kexi/widget/kexieditor.cpp cf7026c 
  kexi/widget/navigator/KexiProjectNavigator.cpp 0692225 
  kexi/widget/pixmapcollection.cpp f529cbe 
  kexi/widget/relations/KexiRelationsScrollArea.cpp e7a1f0f 
  kexi/widget/relations/KexiRelationsTableContainer.cpp 5ae28099 
  kexi/widget/dataviewcommon/kexidataawarepropertyset.cpp 75ce03c 
  kexi/widget/dataviewcommon/kexidataawareview.cpp 8aa9553 
  kexi/widget/fields/KexiFieldComboBox.cpp edd7dc3 
  kexi/widget/fields/KexiFieldListView.cpp ebf6074 
  kexi/widget/KexiDataSourceComboBox.cpp 6066bca 
  kexi/widget/KexiFileWidget.cpp d014f8f 
  kexi/widget/KexiNameWidget.cpp 6157b33 
  kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp deeb867 
  kexi/plugins/tables/kexilookupcolumnpage.cpp 09550e7 
  kexi/plugins/tables/kexitabledesignerview.cpp 4f49d21 
  kexi/plugins/tables/kexitablepart.cpp 8cbf0ba 
  kexi/plugins/forms/widgets/kexidbdatetimeedit.cpp e22188f 
  kexi/plugins/forms/widgets/kexidbimagebox.cpp ef29751 
  kexi/plugins/forms/widgets/kexidblineedit.cpp a711dd7 
  kexi/plugins/forms/widgets/kexidbtimeedit.cpp aa00958 
  kexi/plugins/forms/widgets/mapbrowser/MapBrowserWidget.cpp a772667 
  kexi/plugins/importexport/csv/kexicsvexportwizard.cpp 58020ae 
  kexi/plugins/importexport/csv/kexicsvimportdialog.cpp fe6beb7 
  kexi/plugins/importexport/csv/kexicsvwidgets.cpp e175a25 
  kexi/plugins/queries/kexiquerydesignerguieditor.cpp 6a36eb8 
  kexi/plugins/queries/kexiquerypart.cpp 1407756 
  kexi/plugins/scripting/kexiscripting/kexiscriptdesignview.cpp 93b6b7b 
  kexi/plugins/shapes/relationdesign/kexirelationdesigntool.cpp da32fee 
  kexi/plugins/autoforms/widgets/AutoLineEdit.cpp 38ac33f 
  kexi/plugins/forms/kexidatasourcepage.cpp d55d205 
  kexi/plugins/forms/kexiformmanager.cpp 105979a 
  kexi/plugins/forms/kexiformpart.cpp b276eb7 
  kexi/plugins/forms/kexiformview.cpp 3ffc0a8 
  kexi/plugins/forms/widgets/kexidbdateedit.cpp 5400ff3 
  kexi/main/kexifinddialog.cpp 3734329 
  kexi/main/kexistatusbar.cpp 6d4b447 
  kexi/main/startup/KexiStartupDialog.cpp 011a6a1 
  kexi/main/startup/KexiStartupFileDialog_win.cpp 286b874 
  kexi/main/startup/KexiStartupFileHandler.cpp 6ba57c4 
  kexi/main/startup/KexiStartup_p.cpp 4c4f8da 
  kexi/migration/AlterSchemaWidget.cpp ef9f9f5 
  kexi/mobile/KexiMobileMainWindow.cpp 7a9360d 
  kexi/formeditor/form.cpp 36fc833 
  kexi/formeditor/richtextdialog.cpp e28bcd8 
  kexi/formeditor/tabstopdialog.cpp 134447a 
  kexi/formeditor/widgetlibrary.cpp e8bcd58 
  kexi/main/KexiMainWindow.cpp 50d59c5 
  kexi/formeditor/WidgetTreeWidget.cpp 10ff5d6 
  kexi/formeditor/connectiondialog.cpp ebaad90 
  kexi/formeditor/editlistviewdialog.cpp ea9559c 
  kexi/formeditor/factories/containerfactory.cpp f55055e 
  kexi/core/kexisharedactionhost.cpp 7e9e406 

Diff: http://git.reviewboard.kde.org/r/109057/diff/


Testing
-------

Not tested.  Should be at least inspected but probably also tested by some Kexi developer.


Thanks,

Inge Wallin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130220/2d13a573/attachment.htm>


More information about the calligra-devel mailing list