Review Request 108870: bump min. KDE Platform to 4.6.0 (+ remove no longer needed code branches & port calls of deprecated KCalendarsystem methods)

Friedrich W. H. Kossebau kossebau at kde.org
Sat Feb 9 02:13:44 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108870/
-----------------------------------------------------------

Review request for Calligra, Dag Andersen and Marijn Kruisselbrink.


Description
-------

As discussed on ml calligra-devel (http://lists.kde.org/?t=135930419600001&r=1&w=2), it's time to jump to 4.6.0 as minimal KDE Platform dependency.
Once Inge can report he has upgraded, this should go into master.

Patch also cleans up all then dead code branches. And additionally ports the remaining calls of deprecated KCalendarSystem methods. Sadly there is one call (KCalendarSystem::weekNumber(...)) which only gets deprecated with a substitute call in KDE Platform 4.7, so a few KDE_IS_VERSION have to go in again.

Mainly effected are Plan's and Sheets' code, so cc: the maintainers to give the patch an extra check.


Diffs
-----

  CMakeLists.txt 0d8dfc0 
  filters/plan/mpxj/import/mpxjimport.cpp cebe50d 
  filters/sheets/opencalc/opencalcexport.cc 46d7c59 
  kexi/formeditor/widgetfactory.cpp 3dc9cfa 
  kexi/kexiutils/KexiCategorizedView.h 57eb945 
  libs/main/KoApplication.cpp da90d2b 
  libs/main/KoMainWindow.cpp 625a742 
  libs/main/config/KoConfigGridPage.cpp aa3394b 
  plan/kpttaskdefaultpanel.cpp 3b54e42 
  plan/libs/kernel/KPlatoXmlLoaderBase.cpp fe78979 
  plan/libs/kernel/kptcommand.cpp 852faad 
  plan/libs/kernel/kptdebug.cpp 80f0ef3 
  plan/libs/kernel/kptproject.cpp d67ff53 
  plan/libs/models/kcalendar/kdatepicker.cpp df82168 
  plan/libs/models/kcalendar/kdatetable.cpp 378242b 
  plan/libs/models/kptcalendarmodel.cpp 06a4737 
  plan/libs/ui/kptmainprojectpanel.cpp fa47fc1 
  plan/libs/ui/kptresourcedialog.cpp a25a936 
  plan/libs/ui/kptsummarytaskgeneralpanel.cpp 540a28f 
  plan/libs/ui/kpttaskgeneralpanel.cpp 1123cf9 
  plan/libs/ui/locale/localemon.cpp eece046 
  plan/plugins/scripting/ScriptingPart.cpp c198e46 
  plan/workpackage/debugarea.cpp 725007b 
  sheets/Localization.cpp 28caec1 
  sheets/ValueFormatter.cpp a9850da 
  sheets/plugins/calendar/CalendarTool.cpp 00950e3 
  sheets/ui/CellToolBase.cpp ac0a43f 
  sheets/ui/CellToolBase_p.cpp aa4312f 
  tools/calligra/main.cpp cc30ffa 

Diff: http://git.reviewboard.kde.org/r/108870/diff/


Testing
-------

No changes in local "make test" run.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130209/7178706f/attachment.htm>


More information about the calligra-devel mailing list