Review Request 105559: Perspective grid feature moved to Perspective Assistant

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105559/#review27016
-----------------------------------------------------------


What is the status of this? Are you guys still working on it? Needs improvements? Can be commited? Should be discarded? It's been 3 months without activity!

- Albert Astals Cid


On July 13, 2012, 6:10 p.m., Shivaraman Aiyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105559/
> -----------------------------------------------------------
> 
> (Updated July 13, 2012, 6:10 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> The feature of creating a new grid by pulling the side handles in the Perspective grid which was lacking in the Perspective Assistant has been copied into the Assistant in this commit.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindAssImp.cmake PRE-CREATION 
>   krita/plugins/assistants/RulerAssistant/CMakeLists.txt 957fb4f 
>   krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.h 12f0335 
>   krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.cc 7439511 
>   krita/plugins/tools/tool_perspectivegrid/kis_tool_perspectivegrid.cc df9b75e 
>   krita/ui/kis_painting_assistant.h 2fb513c 
>   krita/ui/kis_painting_assistant.cc 1f619f2 
>   krita/ui/kis_painting_assistants_manager.cc b030aa2 
>   krita/ui/kra/kis_kra_saver.cpp 28d2707 
> 
> Diff: http://git.reviewboard.kde.org/r/105559/diff/
> 
> 
> Testing
> -------
> 
> Basic preliminary testing done include:
> 1) Test if rest of the Assistants are working - done, passed
> 2) Test the working of the side handles - done, passed
> 3) Test if all the assistants working together - done, passed
> 
> 
> Thanks,
> 
> Shivaraman Aiyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130208/0d2772c0/attachment.htm>