Review Request 108725: Fix for unsetting the canvas, new approach

[Sven Langkamp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108725/
-----------------------------------------------------------

(Updated Feb. 3, 2013, 4:35 a.m.)


Review request for Calligra.


Changes
-------

Fixed a problem with the modebox. The canvas on the modebox wasn't set and as it's not set with the other dockers we have to set it seperately.


Description
-------

The patch fixes the unset problem of request 108683. The previous patch had some side effect on Sheets. Now before unset it's check if the canvas of the KoCanvasObserve matches the one which is unset.


This addresses bug 314029.
    http://bugs.kde.org/show_bug.cgi?id=314029


Diffs (updated)
-----

  krita/plugins/extensions/dockers/flipbook/flipbookdocker_dock.cpp 9bc51da 
  libs/flake/KoCanvasControllerWidget.cpp a85337a 
  libs/flake/KoCanvasObserverBase.h 927897c 
  libs/flake/KoCanvasObserverBase.cpp 954fc2e 
  libs/main/KoModeBox.cpp 1c81fa2 
  sheets/part/View.cpp 3adb2f5 
  words/part/KWGui.cpp 607db56 

Diff: http://git.reviewboard.kde.org/r/108725/diff/


Testing
-------

Fixes the bug in Krita. Didn't see side effects on other applications.


Thanks,

Sven Langkamp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130203/28ea746b/attachment.htm>