Review Request 108725: Fix for unsetting the canvas, new approach

Sven Langkamp sven.langkamp at gmail.com
Sat Feb 2 22:54:26 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108725/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

The patch fixes the unset problem of request 108683. The previous patch had some side effect on Sheets. Now before unset it's check if the canvas of the KoCanvasObserve matches the one which is unset.


This addresses bug 314029.
    http://bugs.kde.org/show_bug.cgi?id=314029


Diffs
-----

  krita/plugins/extensions/dockers/flipbook/flipbookdocker_dock.cpp 9bc51da 
  libs/flake/KoCanvasControllerWidget.cpp a85337a 
  libs/flake/KoCanvasObserverBase.h 927897c 
  libs/flake/KoCanvasObserverBase.cpp 954fc2e 

Diff: http://git.reviewboard.kde.org/r/108725/diff/


Testing
-------

Fixes the bug in Krita. Didn't see side effects on other applications.


Thanks,

Sven Langkamp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130202/99672bc7/attachment.htm>


More information about the calligra-devel mailing list