Review Request 108707: fix broken comparison "! value.type() == QVariant::List" in kptcalendarmodel.cpp

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108707/#review26529
-----------------------------------------------------------

Ship it!


Good catch, MSVC :)


- Jarosław Staniek


On Feb. 1, 2013, 11:25 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108707/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2013, 11:25 p.m.)
> 
> 
> Review request for Calligra and Dag Andersen.
> 
> 
> Description
> -------
> 
> Missing the proper knowledge about Plan to test this fix myself, but MSVC is indeed right that this comparison will not work as wanted, as operator! has a higher precedence than operator ==. Patch changes comparison to just use operator !=.
> 
> Might have just worked accidently until now.
> 
> Okay to commit?
> And also backport to 2.6?
> 
> 
> Diffs
> -----
> 
>   plan/libs/models/kptcalendarmodel.cpp 8b482ec 
> 
> Diff: http://git.reviewboard.kde.org/r/108707/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130201/e54a9e4b/attachment.htm>