Review Request 108707: fix broken comparison "! value.type() == QVariant::List" in kptcalendarmodel.cpp

Friedrich W. H. Kossebau kossebau at kde.org
Fri Feb 1 23:25:13 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108707/
-----------------------------------------------------------

Review request for Calligra and Dag Andersen.


Description
-------

Missing the proper knowledge about Plan to test this fix myself, but MSVC is indeed right that this comparison will not work as wanted, as operator! has a higher precedence than operator ==. Patch changes comparison to just use operator !=.

Might have just worked accidently until now.

Okay to commit?
And also backport to 2.6?


Diffs
-----

  plan/libs/models/kptcalendarmodel.cpp 8b482ec 

Diff: http://git.reviewboard.kde.org/r/108707/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130201/e469e58e/attachment.htm>


More information about the calligra-devel mailing list