Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

Boudewijn Rempt boud at valdyas.org
Wed Aug 28 08:31:37 BST 2013 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111747/#review38777
-----------------------------------------------------------


Hm, that diff isn't against the latest master, which makes a review a bit difficult. Can you update that?

- Boudewijn Rempt


On Aug. 28, 2013, 7 a.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111747/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2013, 7 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> An earlier version of this patch has already been up for review before, but now is the time to ask for it to be merged
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d81e039 
>   devtools/rng2cpp/rng2cpp.cpp 3dc3214 
>   filters/libodfreader/OdfTextReader.h 9f37ca7 
>   filters/libodfreader/OdfTextReader.cpp 7a0602b 
>   filters/libodfreader/OdfTextReaderBackend.h bcbe4b2 
>   filters/libodfreader/OdfTextReaderBackend.cpp efd4227 
>   filters/libodfreader/OdtReader.cpp 6fa8ce6 
>   flow/part/FlowView.cpp b30dbe9 
>   karbon/data/karbon_plugin.desktop a210080 
>   kexi/kexidb/drivers/pqxx/pqxxdriver.cpp 17f5110 
>   krita/image/brushengine/kis_paint_information.cc 5dc2515 
>   krita/image/brushengine/kis_paintop_settings.h c0e9dd5 
>   krita/image/brushengine/kis_paintop_settings.cpp f6711f2 
>   krita/image/kis_image.cc e671553 
>   krita/image/kis_mask.cc 98f70e5 
>   krita/image/kis_paint_device.cc 7d0a5c9 
>   krita/image/kis_stroke_strategy.h 4cd054a 
>   krita/image/kis_stroke_strategy.cpp 33f1d15 
>   krita/image/tests/kis_mask_test.h ae11e6f 
>   krita/image/tests/kis_mask_test.cpp 72cc125 
>   krita/image/tests/kis_paint_device_test.h 2057c35 
>   krita/image/tests/kis_paint_device_test.cpp f982ad5 
>   krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp 5aa6a12 
>   krita/plugins/extensions/dockers/overview/krita_overviewdocker.desktop 66776c5 
>   krita/plugins/extensions/imagesplit/wdg_imagesplit.ui 240b9cb 
>   krita/plugins/paintops/defaultpaintops/duplicate/kis_duplicateop.cpp 3ee02d4 
>   krita/plugins/paintops/defaultpaintops/duplicate/kis_duplicateop_settings.h ebe3555 
>   krita/plugins/paintops/defaultpaintops/duplicate/kis_duplicateop_settings.cpp 7558adf 
>   krita/plugins/paintops/dynadraw/kis_dyna_paintop.cpp 73bf9f0 
>   krita/plugins/paintops/filterop/kis_filterop.cpp 2a6c169 
>   krita/plugins/paintops/libbrush/kis_auto_brush.cpp 60613dc 
>   krita/plugins/paintops/libbrush/kis_brush.h 0130364 
>   krita/plugins/paintops/libbrush/kis_brush.cpp ef9331f 
>   krita/plugins/paintops/libbrush/kis_brushes_pipe.h 2506e44 
>   krita/plugins/paintops/libbrush/kis_imagepipe_brush.h cf2fa34 
>   krita/plugins/paintops/libbrush/kis_imagepipe_brush.cpp fe9f264 
>   krita/plugins/paintops/libbrush/kis_text_brush.h 87bb46f 
>   krita/plugins/paintops/libbrush/kis_text_brush.cpp aff9518 
>   krita/plugins/paintops/libbrush/tests/kis_auto_brush_test.cpp edc4700 
>   krita/plugins/paintops/libbrush/tests/kis_imagepipe_brush_test.cpp a760f13 
>   krita/plugins/paintops/libpaintop/kis_compositeop_option.cpp 0229193 
>   krita/plugins/paintops/libpaintop/kis_dab_cache.cpp 54c5f27 
>   krita/plugins/paintops/libpaintop/kis_paintop_options_model.h da2bc97 
>   krita/plugins/paintops/libpaintop/kis_paintop_options_model.cpp 1709422 
>   krita/plugins/paintops/libpaintop/kis_paintop_options_widget.cpp 9c462df 
>   krita/plugins/paintops/libpaintop/kis_text_brush_chooser.cpp d01b7b8 
>   krita/plugins/tools/defaulttools/kis_tool_move.h a3f08fd 
>   krita/plugins/tools/defaulttools/kis_tool_move.cc f3c8171 
>   krita/plugins/tools/selectiontools/kis_tool_select_polygonal.cc 99e69e5 
>   krita/ui/CMakeLists.txt 3cb731b 
>   krita/ui/dialogs/kis_dlg_layer_properties.cc f883304 
>   krita/ui/dialogs/kis_dlg_preferences.cc f872fad 
>   krita/ui/kis_categories_mapper.h 2dee56a 
>   krita/ui/kis_categories_mapper.cpp be9a7d1 
>   krita/ui/kis_categorized_item_delegate.h 851ccda 
>   krita/ui/kis_categorized_item_delegate.cpp 8ae264b 
>   krita/ui/kis_categorized_list_model.h 4d7e6b6 
>   krita/ui/kis_categorized_list_model.cpp c62f39d 
>   krita/ui/kis_composite_ops_model.h 6df7762 
>   krita/ui/kis_composite_ops_model.cc ae71f2e 
>   krita/ui/kis_doc2.cc b063a97 
>   krita/ui/kis_paint_ops_model.h ada430c 
>   krita/ui/kis_paint_ops_model.cpp 1a2f83b 
>   krita/ui/kis_paintop_box.cc e37003c 
>   krita/ui/tests/CMakeLists.txt 555e2b2 
>   krita/ui/tests/data/freehand/freehand_autobrush_300px.kpp_incremental_finished_external.png 98a5356 
>   krita/ui/tests/data/freehand/freehand_autobrush_300px.kpp_incremental_finished_internal.png 98a5356 
>   krita/ui/tests/data/freehand/freehand_autobrush_300px.kpp_indirect_finished_external.png 98a5356 
>   krita/ui/tests/data/freehand/freehand_autobrush_300px.kpp_indirect_finished_internal.png 98a5356 
>   krita/ui/tests/data/freehand/freehand_colorsmudge_predefined.kpp_incremental_finished_external.png 944a9da 
>   krita/ui/tests/data/freehand/freehand_colorsmudge_predefined.kpp_incremental_finished_internal.png 944a9da 
>   krita/ui/tests/data/freehand/freehand_colorsmudge_predefined.kpp_indirect_finished_external.png 944a9da 
>   krita/ui/tests/data/freehand/freehand_colorsmudge_predefined.kpp_indirect_finished_internal.png 944a9da 
>   krita/ui/tests/data/freehand/freehand_hatching_30px.kpp_incremental_finished_external.png be7dd0d 
>   krita/ui/tests/data/freehand/freehand_hatching_30px.kpp_incremental_finished_internal.png be7dd0d 
>   krita/ui/tests/data/freehand/freehand_hatching_30px.kpp_indirect_finished_external.png be7dd0d 
>   krita/ui/tests/data/freehand/freehand_hatching_30px.kpp_indirect_finished_internal.png be7dd0d 
>   krita/ui/tests/freehand_stroke_test.cpp ef7b842 
>   krita/ui/tests/kis_categories_mapper_test.h ecf2cac 
>   krita/ui/tests/kis_categories_mapper_test.cpp 529d504 
>   krita/ui/tests/kis_categorized_list_model_test.h a821333 
>   krita/ui/tests/kis_categorized_list_model_test.cpp a832cd0 
>   krita/ui/tests/testing_categories_mapper.h 6ef62d3 
>   krita/ui/tests/testing_categories_mapper.cpp 1df3f52 
>   krita/ui/tool/kis_figure_painting_tool_helper.cpp 9ea1b1f 
>   krita/ui/tool/kis_resources_snapshot.h 7fe8326 
>   krita/ui/tool/kis_resources_snapshot.cpp 41b680b 
>   krita/ui/tool/kis_tool_freehand_helper.cpp 5127167 
>   krita/ui/tool/kis_tool_polyline_base.h 7d38d24 
>   krita/ui/tool/kis_tool_polyline_base.cpp 37a2ea5 
>   krita/ui/tool/strokes/freehand_stroke.h 7b1a75c 
>   krita/ui/tool/strokes/freehand_stroke.cpp 9130616 
>   krita/ui/tool/strokes/kis_painter_based_stroke_strategy.h e550233 
>   krita/ui/tool/strokes/kis_painter_based_stroke_strategy.cpp 37f9574 
>   krita/ui/widgets/kis_categorized_list_view.h 39476c4 
>   krita/ui/widgets/kis_categorized_list_view.cpp 324fbfe 
>   krita/ui/widgets/kis_cmb_composite.h 8a463bf 
>   krita/ui/widgets/kis_cmb_composite.cc 025688e 
>   krita/ui/widgets/kis_paintop_list_widget.h ca52acb 
>   krita/ui/widgets/kis_paintop_list_widget.cpp f6d4116 
>   libs/basicflakes/tools/KoCreatePathTool.h 101ad4e 
>   libs/basicflakes/tools/KoCreatePathTool.cpp 8f0f547 
>   libs/basicflakes/tools/KoCreatePathTool_p.h 51f4a8f 
>   libs/kopageapp/CMakeLists.txt 7cbf340 
>   libs/kopageapp/KoPAView.h 80b9f78 
>   libs/kopageapp/KoPAView.cpp bb88ee4 
>   libs/kopageapp/tools/backgroundTool/BackgroundToolWidget.ui 937e569 
>   libs/kopageapp/tools/backgroundTool/CMakeLists.txt 339c671 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.h 45a240f 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.cpp 69f7649 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.h cb75621 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp b803e79 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp 505c3da 
>   libs/kopageapp/widgets/KoPABackgroundFillWidget.h PRE-CREATION 
>   libs/kopageapp/widgets/KoPABackgroundFillWidget.cpp PRE-CREATION 
>   libs/main/KoModeBox.cpp a653216 
>   libs/main/KoModeBoxDocker.cpp a6969fd 
>   libs/main/KoModeBoxDocker_p.h f480781 
>   libs/main/KoModeBox_p.h 2d54bf5 
>   libs/widgets/KoFillConfigWidget.h c2d8fca 
>   libs/widgets/KoFillConfigWidget.cpp 3948290 
>   libs/widgets/KoItemToolTip.cpp 2e73458 
>   libs/widgets/KoStrokeConfigWidget.h 8b37d48 
>   libs/widgets/KoStrokeConfigWidget.cpp 4f4ead8 
>   plan/plan_viewplugin.desktop 9979272 
>   plan/plugins/scripting/planscripting.desktop 3d70ffe 
>   plugins/chartshape/calligra_shape_chart.desktop b346a84 
>   plugins/defaultTools/defaulttool/DefaultTool.cpp 0e77389 
>   plugins/dockers/CMakeLists.txt 2c041e7 
>   plugins/dockers/Plugin.cpp 9b6c442 
>   plugins/dockers/styledocker/StrokeFillWidget.h 06082e4 
>   plugins/dockers/styledocker/StrokeFillWidget.cpp 1945a57 
>   plugins/dockers/styledocker/StyleButtonBox.h e2957fa 
>   plugins/dockers/styledocker/StyleButtonBox.cpp 291a5af 
>   plugins/dockers/styledocker/StyleDocker.h 6daa8f4 
>   plugins/dockers/styledocker/StyleDocker.cpp 9f86be9 
>   plugins/dockers/styledocker/StyleDockerFactory.h acd91ac 
>   plugins/dockers/styledocker/StyleDockerFactory.cpp 5898610 
>   plugins/dockers/styledocker/StylePreview.h da81351 
>   plugins/dockers/styledocker/StylePreview.cpp e196fe3 
>   plugins/formulashape/calligra_shape_formular.desktop c61e74b 
>   plugins/staging/pivottables/sheetspivottables.desktop eeec924 
>   plugins/textshape/dialogs/SimpleTableWidget.ui cf9efa0 
>   plugins/videoshape/calligra_shape_video.desktop 0c4da0d 
>   sheets/functions/statistical.xml 8a720f7 
>   sheets/plugins/scripting/sheetsscripting.desktop 4311e6d 
>   sheets/plugins/solver/sheetssolver.desktop 876e655 
>   sheets/shape/calligra_shape_spreadsheet-deferred.desktop 7af9449 
>   sheets/shape/calligra_shape_spreadsheet.desktop ac914fb 
>   sheets/sheets_viewplugin.desktop 6475c8a 
>   stage/part/CMakeLists.txt 65b956e 
>   stage/part/KPrPageLayoutWidget.h PRE-CREATION 
>   stage/part/KPrPageLayoutWidget.cpp PRE-CREATION 
>   stage/part/KPrView.cpp 6ec2402 
>   stage/part/dockers/KPrPageLayoutDocker.h ed7a547 
>   stage/part/dockers/KPrPageLayoutDocker.cpp 8348e2c 
>   words/app/main.cpp 52b599a 
>   words/part/author/author.desktop 3fae4bc 
> 
> Diff: http://git.reviewboard.kde.org/r/111747/diff/
> 
> 
> Testing
> -------
> 
> just working with it, and fixing the reviews from the earlier review
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130828/ca9859e2/attachment.htm>

More information about the calligra-devel mailing list