<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111747/">http://git.reviewboard.kde.org/r/111747/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm, that diff isn't against the latest master, which makes a review a bit difficult. Can you update that?</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On August 28th, 2013, 7 a.m. UTC, C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated Aug. 28, 2013, 7 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">An earlier version of this patch has already been up for review before, but now is the time to ask for it to be merged</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">just working with it, and fixing the reviews from the earlier review</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d81e039)</span></li>
<li>devtools/rng2cpp/rng2cpp.cpp <span style="color: grey">(3dc3214)</span></li>
<li>filters/libodfreader/OdfTextReader.h <span style="color: grey">(9f37ca7)</span></li>
<li>filters/libodfreader/OdfTextReader.cpp <span style="color: grey">(7a0602b)</span></li>
<li>filters/libodfreader/OdfTextReaderBackend.h <span style="color: grey">(bcbe4b2)</span></li>
<li>filters/libodfreader/OdfTextReaderBackend.cpp <span style="color: grey">(efd4227)</span></li>
<li>filters/libodfreader/OdtReader.cpp <span style="color: grey">(6fa8ce6)</span></li>
<li>flow/part/FlowView.cpp <span style="color: grey">(b30dbe9)</span></li>
<li>karbon/data/karbon_plugin.desktop <span style="color: grey">(a210080)</span></li>
<li>kexi/kexidb/drivers/pqxx/pqxxdriver.cpp <span style="color: grey">(17f5110)</span></li>
<li>krita/image/brushengine/kis_paint_information.cc <span style="color: grey">(5dc2515)</span></li>
<li>krita/image/brushengine/kis_paintop_settings.h <span style="color: grey">(c0e9dd5)</span></li>
<li>krita/image/brushengine/kis_paintop_settings.cpp <span style="color: grey">(f6711f2)</span></li>
<li>krita/image/kis_image.cc <span style="color: grey">(e671553)</span></li>
<li>krita/image/kis_mask.cc <span style="color: grey">(98f70e5)</span></li>
<li>krita/image/kis_paint_device.cc <span style="color: grey">(7d0a5c9)</span></li>
<li>krita/image/kis_stroke_strategy.h <span style="color: grey">(4cd054a)</span></li>
<li>krita/image/kis_stroke_strategy.cpp <span style="color: grey">(33f1d15)</span></li>
<li>krita/image/tests/kis_mask_test.h <span style="color: grey">(ae11e6f)</span></li>
<li>krita/image/tests/kis_mask_test.cpp <span style="color: grey">(72cc125)</span></li>
<li>krita/image/tests/kis_paint_device_test.h <span style="color: grey">(2057c35)</span></li>
<li>krita/image/tests/kis_paint_device_test.cpp <span style="color: grey">(f982ad5)</span></li>
<li>krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp <span style="color: grey">(5aa6a12)</span></li>
<li>krita/plugins/extensions/dockers/overview/krita_overviewdocker.desktop <span style="color: grey">(66776c5)</span></li>
<li>krita/plugins/extensions/imagesplit/wdg_imagesplit.ui <span style="color: grey">(240b9cb)</span></li>
<li>krita/plugins/paintops/defaultpaintops/duplicate/kis_duplicateop.cpp <span style="color: grey">(3ee02d4)</span></li>
<li>krita/plugins/paintops/defaultpaintops/duplicate/kis_duplicateop_settings.h <span style="color: grey">(ebe3555)</span></li>
<li>krita/plugins/paintops/defaultpaintops/duplicate/kis_duplicateop_settings.cpp <span style="color: grey">(7558adf)</span></li>
<li>krita/plugins/paintops/dynadraw/kis_dyna_paintop.cpp <span style="color: grey">(73bf9f0)</span></li>
<li>krita/plugins/paintops/filterop/kis_filterop.cpp <span style="color: grey">(2a6c169)</span></li>
<li>krita/plugins/paintops/libbrush/kis_auto_brush.cpp <span style="color: grey">(60613dc)</span></li>
<li>krita/plugins/paintops/libbrush/kis_brush.h <span style="color: grey">(0130364)</span></li>
<li>krita/plugins/paintops/libbrush/kis_brush.cpp <span style="color: grey">(ef9331f)</span></li>
<li>krita/plugins/paintops/libbrush/kis_brushes_pipe.h <span style="color: grey">(2506e44)</span></li>
<li>krita/plugins/paintops/libbrush/kis_imagepipe_brush.h <span style="color: grey">(cf2fa34)</span></li>
<li>krita/plugins/paintops/libbrush/kis_imagepipe_brush.cpp <span style="color: grey">(fe9f264)</span></li>
<li>krita/plugins/paintops/libbrush/kis_text_brush.h <span style="color: grey">(87bb46f)</span></li>
<li>krita/plugins/paintops/libbrush/kis_text_brush.cpp <span style="color: grey">(aff9518)</span></li>
<li>krita/plugins/paintops/libbrush/tests/kis_auto_brush_test.cpp <span style="color: grey">(edc4700)</span></li>
<li>krita/plugins/paintops/libbrush/tests/kis_imagepipe_brush_test.cpp <span style="color: grey">(a760f13)</span></li>
<li>krita/plugins/paintops/libpaintop/kis_compositeop_option.cpp <span style="color: grey">(0229193)</span></li>
<li>krita/plugins/paintops/libpaintop/kis_dab_cache.cpp <span style="color: grey">(54c5f27)</span></li>
<li>krita/plugins/paintops/libpaintop/kis_paintop_options_model.h <span style="color: grey">(da2bc97)</span></li>
<li>krita/plugins/paintops/libpaintop/kis_paintop_options_model.cpp <span style="color: grey">(1709422)</span></li>
<li>krita/plugins/paintops/libpaintop/kis_paintop_options_widget.cpp <span style="color: grey">(9c462df)</span></li>
<li>krita/plugins/paintops/libpaintop/kis_text_brush_chooser.cpp <span style="color: grey">(d01b7b8)</span></li>
<li>krita/plugins/tools/defaulttools/kis_tool_move.h <span style="color: grey">(a3f08fd)</span></li>
<li>krita/plugins/tools/defaulttools/kis_tool_move.cc <span style="color: grey">(f3c8171)</span></li>
<li>krita/plugins/tools/selectiontools/kis_tool_select_polygonal.cc <span style="color: grey">(99e69e5)</span></li>
<li>krita/ui/CMakeLists.txt <span style="color: grey">(3cb731b)</span></li>
<li>krita/ui/dialogs/kis_dlg_layer_properties.cc <span style="color: grey">(f883304)</span></li>
<li>krita/ui/dialogs/kis_dlg_preferences.cc <span style="color: grey">(f872fad)</span></li>
<li>krita/ui/kis_categories_mapper.h <span style="color: grey">(2dee56a)</span></li>
<li>krita/ui/kis_categories_mapper.cpp <span style="color: grey">(be9a7d1)</span></li>
<li>krita/ui/kis_categorized_item_delegate.h <span style="color: grey">(851ccda)</span></li>
<li>krita/ui/kis_categorized_item_delegate.cpp <span style="color: grey">(8ae264b)</span></li>
<li>krita/ui/kis_categorized_list_model.h <span style="color: grey">(4d7e6b6)</span></li>
<li>krita/ui/kis_categorized_list_model.cpp <span style="color: grey">(c62f39d)</span></li>
<li>krita/ui/kis_composite_ops_model.h <span style="color: grey">(6df7762)</span></li>
<li>krita/ui/kis_composite_ops_model.cc <span style="color: grey">(ae71f2e)</span></li>
<li>krita/ui/kis_doc2.cc <span style="color: grey">(b063a97)</span></li>
<li>krita/ui/kis_paint_ops_model.h <span style="color: grey">(ada430c)</span></li>
<li>krita/ui/kis_paint_ops_model.cpp <span style="color: grey">(1a2f83b)</span></li>
<li>krita/ui/kis_paintop_box.cc <span style="color: grey">(e37003c)</span></li>
<li>krita/ui/tests/CMakeLists.txt <span style="color: grey">(555e2b2)</span></li>
<li>krita/ui/tests/data/freehand/freehand_autobrush_300px.kpp_incremental_finished_external.png <span style="color: grey">(98a5356)</span></li>
<li>krita/ui/tests/data/freehand/freehand_autobrush_300px.kpp_incremental_finished_internal.png <span style="color: grey">(98a5356)</span></li>
<li>krita/ui/tests/data/freehand/freehand_autobrush_300px.kpp_indirect_finished_external.png <span style="color: grey">(98a5356)</span></li>
<li>krita/ui/tests/data/freehand/freehand_autobrush_300px.kpp_indirect_finished_internal.png <span style="color: grey">(98a5356)</span></li>
<li>krita/ui/tests/data/freehand/freehand_colorsmudge_predefined.kpp_incremental_finished_external.png <span style="color: grey">(944a9da)</span></li>
<li>krita/ui/tests/data/freehand/freehand_colorsmudge_predefined.kpp_incremental_finished_internal.png <span style="color: grey">(944a9da)</span></li>
<li>krita/ui/tests/data/freehand/freehand_colorsmudge_predefined.kpp_indirect_finished_external.png <span style="color: grey">(944a9da)</span></li>
<li>krita/ui/tests/data/freehand/freehand_colorsmudge_predefined.kpp_indirect_finished_internal.png <span style="color: grey">(944a9da)</span></li>
<li>krita/ui/tests/data/freehand/freehand_hatching_30px.kpp_incremental_finished_external.png <span style="color: grey">(be7dd0d)</span></li>
<li>krita/ui/tests/data/freehand/freehand_hatching_30px.kpp_incremental_finished_internal.png <span style="color: grey">(be7dd0d)</span></li>
<li>krita/ui/tests/data/freehand/freehand_hatching_30px.kpp_indirect_finished_external.png <span style="color: grey">(be7dd0d)</span></li>
<li>krita/ui/tests/data/freehand/freehand_hatching_30px.kpp_indirect_finished_internal.png <span style="color: grey">(be7dd0d)</span></li>
<li>krita/ui/tests/freehand_stroke_test.cpp <span style="color: grey">(ef7b842)</span></li>
<li>krita/ui/tests/kis_categories_mapper_test.h <span style="color: grey">(ecf2cac)</span></li>
<li>krita/ui/tests/kis_categories_mapper_test.cpp <span style="color: grey">(529d504)</span></li>
<li>krita/ui/tests/kis_categorized_list_model_test.h <span style="color: grey">(a821333)</span></li>
<li>krita/ui/tests/kis_categorized_list_model_test.cpp <span style="color: grey">(a832cd0)</span></li>
<li>krita/ui/tests/testing_categories_mapper.h <span style="color: grey">(6ef62d3)</span></li>
<li>krita/ui/tests/testing_categories_mapper.cpp <span style="color: grey">(1df3f52)</span></li>
<li>krita/ui/tool/kis_figure_painting_tool_helper.cpp <span style="color: grey">(9ea1b1f)</span></li>
<li>krita/ui/tool/kis_resources_snapshot.h <span style="color: grey">(7fe8326)</span></li>
<li>krita/ui/tool/kis_resources_snapshot.cpp <span style="color: grey">(41b680b)</span></li>
<li>krita/ui/tool/kis_tool_freehand_helper.cpp <span style="color: grey">(5127167)</span></li>
<li>krita/ui/tool/kis_tool_polyline_base.h <span style="color: grey">(7d38d24)</span></li>
<li>krita/ui/tool/kis_tool_polyline_base.cpp <span style="color: grey">(37a2ea5)</span></li>
<li>krita/ui/tool/strokes/freehand_stroke.h <span style="color: grey">(7b1a75c)</span></li>
<li>krita/ui/tool/strokes/freehand_stroke.cpp <span style="color: grey">(9130616)</span></li>
<li>krita/ui/tool/strokes/kis_painter_based_stroke_strategy.h <span style="color: grey">(e550233)</span></li>
<li>krita/ui/tool/strokes/kis_painter_based_stroke_strategy.cpp <span style="color: grey">(37f9574)</span></li>
<li>krita/ui/widgets/kis_categorized_list_view.h <span style="color: grey">(39476c4)</span></li>
<li>krita/ui/widgets/kis_categorized_list_view.cpp <span style="color: grey">(324fbfe)</span></li>
<li>krita/ui/widgets/kis_cmb_composite.h <span style="color: grey">(8a463bf)</span></li>
<li>krita/ui/widgets/kis_cmb_composite.cc <span style="color: grey">(025688e)</span></li>
<li>krita/ui/widgets/kis_paintop_list_widget.h <span style="color: grey">(ca52acb)</span></li>
<li>krita/ui/widgets/kis_paintop_list_widget.cpp <span style="color: grey">(f6d4116)</span></li>
<li>libs/basicflakes/tools/KoCreatePathTool.h <span style="color: grey">(101ad4e)</span></li>
<li>libs/basicflakes/tools/KoCreatePathTool.cpp <span style="color: grey">(8f0f547)</span></li>
<li>libs/basicflakes/tools/KoCreatePathTool_p.h <span style="color: grey">(51f4a8f)</span></li>
<li>libs/kopageapp/CMakeLists.txt <span style="color: grey">(7cbf340)</span></li>
<li>libs/kopageapp/KoPAView.h <span style="color: grey">(80b9f78)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(bb88ee4)</span></li>
<li>libs/kopageapp/tools/backgroundTool/BackgroundToolWidget.ui <span style="color: grey">(937e569)</span></li>
<li>libs/kopageapp/tools/backgroundTool/CMakeLists.txt <span style="color: grey">(339c671)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.h <span style="color: grey">(45a240f)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.cpp <span style="color: grey">(69f7649)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.h <span style="color: grey">(cb75621)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp <span style="color: grey">(b803e79)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp <span style="color: grey">(505c3da)</span></li>
<li>libs/kopageapp/widgets/KoPABackgroundFillWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kopageapp/widgets/KoPABackgroundFillWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/KoModeBox.cpp <span style="color: grey">(a653216)</span></li>
<li>libs/main/KoModeBoxDocker.cpp <span style="color: grey">(a6969fd)</span></li>
<li>libs/main/KoModeBoxDocker_p.h <span style="color: grey">(f480781)</span></li>
<li>libs/main/KoModeBox_p.h <span style="color: grey">(2d54bf5)</span></li>
<li>libs/widgets/KoFillConfigWidget.h <span style="color: grey">(c2d8fca)</span></li>
<li>libs/widgets/KoFillConfigWidget.cpp <span style="color: grey">(3948290)</span></li>
<li>libs/widgets/KoItemToolTip.cpp <span style="color: grey">(2e73458)</span></li>
<li>libs/widgets/KoStrokeConfigWidget.h <span style="color: grey">(8b37d48)</span></li>
<li>libs/widgets/KoStrokeConfigWidget.cpp <span style="color: grey">(4f4ead8)</span></li>
<li>plan/plan_viewplugin.desktop <span style="color: grey">(9979272)</span></li>
<li>plan/plugins/scripting/planscripting.desktop <span style="color: grey">(3d70ffe)</span></li>
<li>plugins/chartshape/calligra_shape_chart.desktop <span style="color: grey">(b346a84)</span></li>
<li>plugins/defaultTools/defaulttool/DefaultTool.cpp <span style="color: grey">(0e77389)</span></li>
<li>plugins/dockers/CMakeLists.txt <span style="color: grey">(2c041e7)</span></li>
<li>plugins/dockers/Plugin.cpp <span style="color: grey">(9b6c442)</span></li>
<li>plugins/dockers/styledocker/StrokeFillWidget.h <span style="color: grey">(06082e4)</span></li>
<li>plugins/dockers/styledocker/StrokeFillWidget.cpp <span style="color: grey">(1945a57)</span></li>
<li>plugins/dockers/styledocker/StyleButtonBox.h <span style="color: grey">(e2957fa)</span></li>
<li>plugins/dockers/styledocker/StyleButtonBox.cpp <span style="color: grey">(291a5af)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.h <span style="color: grey">(6daa8f4)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.cpp <span style="color: grey">(9f86be9)</span></li>
<li>plugins/dockers/styledocker/StyleDockerFactory.h <span style="color: grey">(acd91ac)</span></li>
<li>plugins/dockers/styledocker/StyleDockerFactory.cpp <span style="color: grey">(5898610)</span></li>
<li>plugins/dockers/styledocker/StylePreview.h <span style="color: grey">(da81351)</span></li>
<li>plugins/dockers/styledocker/StylePreview.cpp <span style="color: grey">(e196fe3)</span></li>
<li>plugins/formulashape/calligra_shape_formular.desktop <span style="color: grey">(c61e74b)</span></li>
<li>plugins/staging/pivottables/sheetspivottables.desktop <span style="color: grey">(eeec924)</span></li>
<li>plugins/textshape/dialogs/SimpleTableWidget.ui <span style="color: grey">(cf9efa0)</span></li>
<li>plugins/videoshape/calligra_shape_video.desktop <span style="color: grey">(0c4da0d)</span></li>
<li>sheets/functions/statistical.xml <span style="color: grey">(8a720f7)</span></li>
<li>sheets/plugins/scripting/sheetsscripting.desktop <span style="color: grey">(4311e6d)</span></li>
<li>sheets/plugins/solver/sheetssolver.desktop <span style="color: grey">(876e655)</span></li>
<li>sheets/shape/calligra_shape_spreadsheet-deferred.desktop <span style="color: grey">(7af9449)</span></li>
<li>sheets/shape/calligra_shape_spreadsheet.desktop <span style="color: grey">(ac914fb)</span></li>
<li>sheets/sheets_viewplugin.desktop <span style="color: grey">(6475c8a)</span></li>
<li>stage/part/CMakeLists.txt <span style="color: grey">(65b956e)</span></li>
<li>stage/part/KPrPageLayoutWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrPageLayoutWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrView.cpp <span style="color: grey">(6ec2402)</span></li>
<li>stage/part/dockers/KPrPageLayoutDocker.h <span style="color: grey">(ed7a547)</span></li>
<li>stage/part/dockers/KPrPageLayoutDocker.cpp <span style="color: grey">(8348e2c)</span></li>
<li>words/app/main.cpp <span style="color: grey">(52b599a)</span></li>
<li>words/part/author/author.desktop <span style="color: grey">(3fae4bc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111747/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>