Review Request 110162: Move KexiTableViewColumn and KexiTableViewData to calligradb

Jarosław Staniek staniek at kde.org
Tue Apr 30 22:32:55 BST 2013 


> On April 29, 2013, 9:46 p.m., Tomasz Olszak wrote:
> > kexi/kexiutils/multivalidator.h, line 44
> > <http://git.reviewboard.kde.org/r/110162/diff/1/?file=140815#file140815line44>
> >
> >     ust? - I suppose it's kind of misspelling.

fixed


> On April 29, 2013, 9:46 p.m., Tomasz Olszak wrote:
> > kexi/migration/mdb/src/keximdb/mdbmigrate.cpp, line 130
> > <http://git.reviewboard.kde.org/r/110162/diff/1/?file=140820#file140820line130>
> >
> >     Is there any reason for not removing this line?

changes from kexi/migration/mdb/src/keximdb/ should not go here at all, fixed


> On April 29, 2013, 9:46 p.m., Tomasz Olszak wrote:
> > kexi/widget/dataviewcommon/kexidataawarepropertyset.h, line 37
> > <http://git.reviewboard.kde.org/r/110162/diff/1/?file=140842#file140842line37>
> >
> >     do we need forward declaration if we include <db/tableviewdata.h>? Or maybe we shouldn't include this if we have forward declaration.

fixed, thanks; if everything's OK please click "Ship it"


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110162/#review31774
-----------------------------------------------------------


On April 24, 2013, 9:09 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110162/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 9:09 p.m.)
> 
> 
> Review request for Calligra, Oleg Kukharchuk, Adam Pigg, Smit Patel, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.
> 
> 
> Description
> -------
> 
> Move KexiTableViewColumn and KexiTableViewData to calligradb. Needed by the bibliography editor in Words.
> 
> This patch also contains Kexi code ported to the moved API.
> 
> 
> Diffs
> -----
> 
>   kexi/core/kexi.h 60c56ae16bde396f69da4084ea0011a69e180c7d 
>   kexi/core/kexi.cpp 087183fcb3786ea795dbdb214b8f27e4517df597 
>   kexi/formeditor/connectiondialog.h a7ad95059281692a504c38c5516a64388babec07 
>   kexi/formeditor/connectiondialog.cpp 9de87e363cedff032d8d4677e198293f6f28049e 
>   kexi/formeditor/kexiformeventhandler.cpp 99bee7e0c50edf7f8ee8ba8086df7d914a43765f 
>   kexi/kexidb/dbobjectnamevalidator.h 27ed4fa5449e5b50a1fb34047cedf709a9e043de 
>   kexi/kexidb/dbobjectnamevalidator.cpp af21f1aa4f26ad22187a52eacf8b2d84ed67f82e 
>   kexi/kexidb/fieldvalidator.h 5f2f06dedcab83c5704729e87bbfc59459979660 
>   kexi/kexiutils/CMakeLists.txt 19a3320b9138b54fdbbe1fee14dabb70cd1b9ba8 
>   kexi/kexiutils/identifier.h 7469c391f51e10000c5f065b133a4975efa572e3 
>   kexi/kexiutils/identifier.cpp 852166cdbcfebfbe98847f4e00c214677bf97270 
>   kexi/kexiutils/multivalidator.h PRE-CREATION 
>   kexi/kexiutils/multivalidator.cpp PRE-CREATION 
>   kexi/kexiutils/validator.h 0404a21b9c053cd9da49607e95dfe6bc2232d4e4 
>   kexi/kexiutils/validator.cpp 4eeb037b553b98a18b5fe34fdfe12db953b94620 
>   kexi/main/KexiMainWindow_p.h 3aa1c5521d289838756484aa1c9a105ea6f6d37a 
>   kexi/migration/mdb/src/keximdb/mdbmigrate.cpp 343f11b3293f4dfd7b15ace6a9728440a12cb9f3 
>   kexi/plugins/autoforms/KexiAutoFormView.cpp c715f644159222d64bbfd9f29339e8e12d3dc510 
>   kexi/plugins/autoforms/widgets/AutoForm.h 7df525c9aaa896b387b2bb2b7470cd0ef895be8f 
>   kexi/plugins/autoforms/widgets/AutoForm.cpp eeb2a6ee583b32f70467838eaacfe112fa8f2c83 
>   kexi/plugins/forms/kexiformmanager.cpp 840ae364ccaf50cb72bcb184efd085823f6c7dd6 
>   kexi/plugins/forms/kexiformscrollview.h e5c01651f42e899dab8d9689a0bb026c2782da25 
>   kexi/plugins/forms/kexiformscrollview.cpp ddd9bf15ccb4aff5bb8d580dc4eebe714515b663 
>   kexi/plugins/forms/kexiformview.cpp bc91848dd205821ae50a08b6d1be31dd602a9b66 
>   kexi/plugins/forms/widgets/kexidbcombobox.h 06f4d7a2ae2a547afc066ab7b1d6f49f5caa536a 
>   kexi/plugins/queries/kexiquerydesignerguieditor.cpp c95c79c0075ced9b31ee63953d909a291b2a30c0 
>   kexi/plugins/tables/kexitabledesignerview.cpp ebf2ee8a6eacc31e305977909c86215780e170c0 
>   kexi/plugins/tables/kexitabledesignerview_p.h f567a05a5412d187f02b57edde9a8e6aaae009df 
>   kexi/tests/startup/main.cpp 6a1b3f1368801421be5593ccb41d9d6becacc01f 
>   kexi/tests/tableview/main.cpp 479b8b732b1958c8b5490f32fa79d4fbc6dfe148 
>   kexi/widget/KexiNameWidget.h b71620826990b7b08c6dc1fecf901901741f1dc7 
>   kexi/widget/KexiNameWidget.cpp 97cdff0d64e267e1e62195e915ee0b6af296fa21 
>   kexi/widget/dataviewcommon/CMakeLists.txt 37ec0fad927bec6c95f4edcaeffb6da1b0321200 
>   kexi/widget/dataviewcommon/KexiTableViewColumn.h 9be4d89149c33bf0a30a491b7eeb58a0445524cc 
>   kexi/widget/dataviewcommon/KexiTableViewColumn.cpp 1f6ef7412d7aa6d454070511640187238e9bac3f 
>   kexi/widget/dataviewcommon/chartable.txt a52b0b55e618a27f97af97dcd417817354a48147 
>   kexi/widget/dataviewcommon/kexidataawareobjectiface.h 20472f78d666aa961ccbe08477ce9f6649c28cb3 
>   kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp ddc08a5f8687da1a88faab7cd2b2edb79bd48216 
>   kexi/widget/dataviewcommon/kexidataawarepropertyset.h 33f750ea160938522fdd21d72b782d40d6f2d3e4 
>   kexi/widget/dataviewcommon/kexidataawarepropertyset.cpp c261cfcbcfe4d4f6cfe2155c2069b098863340ec 
>   kexi/widget/dataviewcommon/kexidataawareview.cpp 2e2a526d1bdef3a85d2e456dbc0c7e2aff8e7545 
>   kexi/widget/dataviewcommon/kexidataprovider.cpp 9025b4010fe6caaa311f650ba22f5ec7eadbc936 
>   kexi/widget/dataviewcommon/kexitableviewdata.h 1241d970355bd85ed072be02bf273b855d0963e4 
>   kexi/widget/dataviewcommon/kexitableviewdata.cpp a06c549c09b17e595902a0648ddea88ec772b5e9 
>   kexi/widget/tableview/kexiblobtableedit.h a3c22efb5e03114a06c941c1c1640d9f65961983 
>   kexi/widget/tableview/kexiblobtableedit.cpp 98aefae79ad0091ea90b944adc3bd9f9de967f38 
>   kexi/widget/tableview/kexibooltableedit.h 9055feb3e768e5dc3053acc068dd1964fa2ac056 
>   kexi/widget/tableview/kexibooltableedit.cpp de59c64e8d702efc91894cc5eba7496db8ca2ac1 
>   kexi/widget/tableview/kexicelleditorfactory.h 47ff33e7fa58598d3dbf5e22df0ab5263de861f6 
>   kexi/widget/tableview/kexicelleditorfactory.cpp bf011218eaea5fecbce475482c82d027ea256852 
>   kexi/widget/tableview/kexicomboboxbase.h 4c72a1ce1999f8ed7d2dc0f32ce077e6e3e3e736 
>   kexi/widget/tableview/kexicomboboxbase.cpp 226b3007914c0c8db2074976aa1bb32cc58f05db 
>   kexi/widget/tableview/kexicomboboxpopup.h 7c942f5d8dbf5961f5835b7c398c0298f9506eb7 
>   kexi/widget/tableview/kexicomboboxpopup.cpp a1010adcf531a938e6aae9c82d664599eaa16b16 
>   kexi/widget/tableview/kexicomboboxtableedit.h 044239062d6d7eb5b2cf06a6a6e42f89336dd452 
>   kexi/widget/tableview/kexicomboboxtableedit.cpp d4ec07bc946fff64ebc4f803cd62c661147e8b05 
>   kexi/widget/tableview/kexidatatable.h e8ddae7b37e40c87e35aafed6eb9cb43671877a3 
>   kexi/widget/tableview/kexidatatable.cpp 6a1f72a9e012eab01675232b8848685e57202460 
>   kexi/widget/tableview/kexidatatableview.cpp a14c5e915f1a8c95bdb4358f854cf6261991ea1d 
>   kexi/widget/tableview/kexidatetableedit.h 6dfb400cfa5a4778600e88e52ca1341e6e76a091 
>   kexi/widget/tableview/kexidatetableedit.cpp f8685bb80d1822e7ce85844911166085def7d239 
>   kexi/widget/tableview/kexidatetimetableedit.h 16e4b78a2043c481d61c9dfffe0e1e655f6911f9 
>   kexi/widget/tableview/kexidatetimetableedit.cpp 6c718b5e9ae0aa13e297212f23decb90074c9411 
>   kexi/widget/tableview/kexiinputtableedit.h 999d633ced0c34d8202cd699136455bbe391c20d 
>   kexi/widget/tableview/kexiinputtableedit.cpp 72ddb56fb57878318d03213ea749f645976b8090 
>   kexi/widget/tableview/kexitableedit.h 5119f5e02157bf86f4e29e523980413157d4ad6c 
>   kexi/widget/tableview/kexitableedit.cpp 7d14355d649e300dfd64a4436f40c151844d159e 
>   kexi/widget/tableview/kexitableview.h ca8b10ee4a99a751a86902fbef34d0f00b09fa4f 
>   kexi/widget/tableview/kexitableview.cpp eab56fc6f42a0519d9e6bfb6b2336707186037fc 
>   kexi/widget/tableview/kexitableview_p.h e578dfb87fc2d70e9d71cbf92c0e61eb2531e54c 
>   kexi/widget/tableview/kexitimetableedit.h 813cd8a8fde61e1559f18ff8da57e599c94558d9 
>   kexi/widget/tableview/kexitimetableedit.cpp e5c6f1543d7255f0ddb00379eec69260266c498d 
>   libs/db/CMakeLists.txt c0d99e8e55d58068eab6b6f09bfddc63e03d55cf 
>   libs/db/chartable.txt PRE-CREATION 
>   libs/db/global.h b6429593185d1218f590dfae3daf401388fff807 
>   libs/db/global.cpp eebd6391dcfa018078fe2ebe310fb5b4fbf38c96 
>   libs/db/tableviewcolumn.h PRE-CREATION 
>   libs/db/tableviewcolumn.cpp PRE-CREATION 
>   libs/db/tableviewdata.h PRE-CREATION 
>   libs/db/tableviewdata.cpp PRE-CREATION 
>   libs/db/validator.h PRE-CREATION 
>   libs/db/validator.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110162/diff/
> 
> 
> Testing
> -------
> 
> Kexi works like before
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130430/26bf06a6/attachment.htm>

More information about the calligra-devel mailing list