<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110162/">http://git.reviewboard.kde.org/r/110162/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 29th, 2013, 9:46 p.m. UTC, <b>Tomasz Olszak</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110162/diff/1/?file=140815#file140815line44" style="color: black; font-weight: bold; text-decoration: underline;">kexi/kexiutils/multivalidator.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> - If a given subvalidator is not of class Validator but ust QValidator,</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ust? - I suppose it's kind of misspelling.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">fixed</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 29th, 2013, 9:46 p.m. UTC, <b>Tomasz Olszak</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110162/diff/1/?file=140820#file140820line130" style="color: black; font-weight: bold; text-decoration: underline;">kexi/migration/mdb/src/keximdb/mdbmigrate.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool MDBMigrate::drv_disconnect()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">129</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">kDebug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">tableName</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">127</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1"><span class="hl">//</span>kDebug() << tableName;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is there any reason for not removing this line?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">changes from kexi/migration/mdb/src/keximdb/ should not go here at all, fixed</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 29th, 2013, 9:46 p.m. UTC, <b>Tomasz Olszak</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110162/diff/1/?file=140842#file140842line37" style="color: black; font-weight: bold; text-decoration: underline;">kexi/widget/dataviewcommon/kexidataawarepropertyset.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">36</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="p">}</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">do we need forward declaration if we include <db/tableviewdata.h>? Or maybe we shouldn't include this if we have forward declaration. </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">fixed, thanks; if everything's OK please click "Ship it"</pre>
<br />
<p>- Jarosław</p>
<br />
<p>On April 24th, 2013, 9:09 p.m. UTC, Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Oleg Kukharchuk, Adam Pigg, Smit Patel, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated April 24, 2013, 9:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move KexiTableViewColumn and KexiTableViewData to calligradb. Needed by the bibliography editor in Words.
This patch also contains Kexi code ported to the moved API.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Kexi works like before</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/core/kexi.h <span style="color: grey">(60c56ae16bde396f69da4084ea0011a69e180c7d)</span></li>
<li>kexi/core/kexi.cpp <span style="color: grey">(087183fcb3786ea795dbdb214b8f27e4517df597)</span></li>
<li>kexi/formeditor/connectiondialog.h <span style="color: grey">(a7ad95059281692a504c38c5516a64388babec07)</span></li>
<li>kexi/formeditor/connectiondialog.cpp <span style="color: grey">(9de87e363cedff032d8d4677e198293f6f28049e)</span></li>
<li>kexi/formeditor/kexiformeventhandler.cpp <span style="color: grey">(99bee7e0c50edf7f8ee8ba8086df7d914a43765f)</span></li>
<li>kexi/kexidb/dbobjectnamevalidator.h <span style="color: grey">(27ed4fa5449e5b50a1fb34047cedf709a9e043de)</span></li>
<li>kexi/kexidb/dbobjectnamevalidator.cpp <span style="color: grey">(af21f1aa4f26ad22187a52eacf8b2d84ed67f82e)</span></li>
<li>kexi/kexidb/fieldvalidator.h <span style="color: grey">(5f2f06dedcab83c5704729e87bbfc59459979660)</span></li>
<li>kexi/kexiutils/CMakeLists.txt <span style="color: grey">(19a3320b9138b54fdbbe1fee14dabb70cd1b9ba8)</span></li>
<li>kexi/kexiutils/identifier.h <span style="color: grey">(7469c391f51e10000c5f065b133a4975efa572e3)</span></li>
<li>kexi/kexiutils/identifier.cpp <span style="color: grey">(852166cdbcfebfbe98847f4e00c214677bf97270)</span></li>
<li>kexi/kexiutils/multivalidator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/kexiutils/multivalidator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/kexiutils/validator.h <span style="color: grey">(0404a21b9c053cd9da49607e95dfe6bc2232d4e4)</span></li>
<li>kexi/kexiutils/validator.cpp <span style="color: grey">(4eeb037b553b98a18b5fe34fdfe12db953b94620)</span></li>
<li>kexi/main/KexiMainWindow_p.h <span style="color: grey">(3aa1c5521d289838756484aa1c9a105ea6f6d37a)</span></li>
<li>kexi/migration/mdb/src/keximdb/mdbmigrate.cpp <span style="color: grey">(343f11b3293f4dfd7b15ace6a9728440a12cb9f3)</span></li>
<li>kexi/plugins/autoforms/KexiAutoFormView.cpp <span style="color: grey">(c715f644159222d64bbfd9f29339e8e12d3dc510)</span></li>
<li>kexi/plugins/autoforms/widgets/AutoForm.h <span style="color: grey">(7df525c9aaa896b387b2bb2b7470cd0ef895be8f)</span></li>
<li>kexi/plugins/autoforms/widgets/AutoForm.cpp <span style="color: grey">(eeb2a6ee583b32f70467838eaacfe112fa8f2c83)</span></li>
<li>kexi/plugins/forms/kexiformmanager.cpp <span style="color: grey">(840ae364ccaf50cb72bcb184efd085823f6c7dd6)</span></li>
<li>kexi/plugins/forms/kexiformscrollview.h <span style="color: grey">(e5c01651f42e899dab8d9689a0bb026c2782da25)</span></li>
<li>kexi/plugins/forms/kexiformscrollview.cpp <span style="color: grey">(ddd9bf15ccb4aff5bb8d580dc4eebe714515b663)</span></li>
<li>kexi/plugins/forms/kexiformview.cpp <span style="color: grey">(bc91848dd205821ae50a08b6d1be31dd602a9b66)</span></li>
<li>kexi/plugins/forms/widgets/kexidbcombobox.h <span style="color: grey">(06f4d7a2ae2a547afc066ab7b1d6f49f5caa536a)</span></li>
<li>kexi/plugins/queries/kexiquerydesignerguieditor.cpp <span style="color: grey">(c95c79c0075ced9b31ee63953d909a291b2a30c0)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview.cpp <span style="color: grey">(ebf2ee8a6eacc31e305977909c86215780e170c0)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview_p.h <span style="color: grey">(f567a05a5412d187f02b57edde9a8e6aaae009df)</span></li>
<li>kexi/tests/startup/main.cpp <span style="color: grey">(6a1b3f1368801421be5593ccb41d9d6becacc01f)</span></li>
<li>kexi/tests/tableview/main.cpp <span style="color: grey">(479b8b732b1958c8b5490f32fa79d4fbc6dfe148)</span></li>
<li>kexi/widget/KexiNameWidget.h <span style="color: grey">(b71620826990b7b08c6dc1fecf901901741f1dc7)</span></li>
<li>kexi/widget/KexiNameWidget.cpp <span style="color: grey">(97cdff0d64e267e1e62195e915ee0b6af296fa21)</span></li>
<li>kexi/widget/dataviewcommon/CMakeLists.txt <span style="color: grey">(37ec0fad927bec6c95f4edcaeffb6da1b0321200)</span></li>
<li>kexi/widget/dataviewcommon/KexiTableViewColumn.h <span style="color: grey">(9be4d89149c33bf0a30a491b7eeb58a0445524cc)</span></li>
<li>kexi/widget/dataviewcommon/KexiTableViewColumn.cpp <span style="color: grey">(1f6ef7412d7aa6d454070511640187238e9bac3f)</span></li>
<li>kexi/widget/dataviewcommon/chartable.txt <span style="color: grey">(a52b0b55e618a27f97af97dcd417817354a48147)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.h <span style="color: grey">(20472f78d666aa961ccbe08477ce9f6649c28cb3)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp <span style="color: grey">(ddc08a5f8687da1a88faab7cd2b2edb79bd48216)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawarepropertyset.h <span style="color: grey">(33f750ea160938522fdd21d72b782d40d6f2d3e4)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawarepropertyset.cpp <span style="color: grey">(c261cfcbcfe4d4f6cfe2155c2069b098863340ec)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareview.cpp <span style="color: grey">(2e2a526d1bdef3a85d2e456dbc0c7e2aff8e7545)</span></li>
<li>kexi/widget/dataviewcommon/kexidataprovider.cpp <span style="color: grey">(9025b4010fe6caaa311f650ba22f5ec7eadbc936)</span></li>
<li>kexi/widget/dataviewcommon/kexitableviewdata.h <span style="color: grey">(1241d970355bd85ed072be02bf273b855d0963e4)</span></li>
<li>kexi/widget/dataviewcommon/kexitableviewdata.cpp <span style="color: grey">(a06c549c09b17e595902a0648ddea88ec772b5e9)</span></li>
<li>kexi/widget/tableview/kexiblobtableedit.h <span style="color: grey">(a3c22efb5e03114a06c941c1c1640d9f65961983)</span></li>
<li>kexi/widget/tableview/kexiblobtableedit.cpp <span style="color: grey">(98aefae79ad0091ea90b944adc3bd9f9de967f38)</span></li>
<li>kexi/widget/tableview/kexibooltableedit.h <span style="color: grey">(9055feb3e768e5dc3053acc068dd1964fa2ac056)</span></li>
<li>kexi/widget/tableview/kexibooltableedit.cpp <span style="color: grey">(de59c64e8d702efc91894cc5eba7496db8ca2ac1)</span></li>
<li>kexi/widget/tableview/kexicelleditorfactory.h <span style="color: grey">(47ff33e7fa58598d3dbf5e22df0ab5263de861f6)</span></li>
<li>kexi/widget/tableview/kexicelleditorfactory.cpp <span style="color: grey">(bf011218eaea5fecbce475482c82d027ea256852)</span></li>
<li>kexi/widget/tableview/kexicomboboxbase.h <span style="color: grey">(4c72a1ce1999f8ed7d2dc0f32ce077e6e3e3e736)</span></li>
<li>kexi/widget/tableview/kexicomboboxbase.cpp <span style="color: grey">(226b3007914c0c8db2074976aa1bb32cc58f05db)</span></li>
<li>kexi/widget/tableview/kexicomboboxpopup.h <span style="color: grey">(7c942f5d8dbf5961f5835b7c398c0298f9506eb7)</span></li>
<li>kexi/widget/tableview/kexicomboboxpopup.cpp <span style="color: grey">(a1010adcf531a938e6aae9c82d664599eaa16b16)</span></li>
<li>kexi/widget/tableview/kexicomboboxtableedit.h <span style="color: grey">(044239062d6d7eb5b2cf06a6a6e42f89336dd452)</span></li>
<li>kexi/widget/tableview/kexicomboboxtableedit.cpp <span style="color: grey">(d4ec07bc946fff64ebc4f803cd62c661147e8b05)</span></li>
<li>kexi/widget/tableview/kexidatatable.h <span style="color: grey">(e8ddae7b37e40c87e35aafed6eb9cb43671877a3)</span></li>
<li>kexi/widget/tableview/kexidatatable.cpp <span style="color: grey">(6a1f72a9e012eab01675232b8848685e57202460)</span></li>
<li>kexi/widget/tableview/kexidatatableview.cpp <span style="color: grey">(a14c5e915f1a8c95bdb4358f854cf6261991ea1d)</span></li>
<li>kexi/widget/tableview/kexidatetableedit.h <span style="color: grey">(6dfb400cfa5a4778600e88e52ca1341e6e76a091)</span></li>
<li>kexi/widget/tableview/kexidatetableedit.cpp <span style="color: grey">(f8685bb80d1822e7ce85844911166085def7d239)</span></li>
<li>kexi/widget/tableview/kexidatetimetableedit.h <span style="color: grey">(16e4b78a2043c481d61c9dfffe0e1e655f6911f9)</span></li>
<li>kexi/widget/tableview/kexidatetimetableedit.cpp <span style="color: grey">(6c718b5e9ae0aa13e297212f23decb90074c9411)</span></li>
<li>kexi/widget/tableview/kexiinputtableedit.h <span style="color: grey">(999d633ced0c34d8202cd699136455bbe391c20d)</span></li>
<li>kexi/widget/tableview/kexiinputtableedit.cpp <span style="color: grey">(72ddb56fb57878318d03213ea749f645976b8090)</span></li>
<li>kexi/widget/tableview/kexitableedit.h <span style="color: grey">(5119f5e02157bf86f4e29e523980413157d4ad6c)</span></li>
<li>kexi/widget/tableview/kexitableedit.cpp <span style="color: grey">(7d14355d649e300dfd64a4436f40c151844d159e)</span></li>
<li>kexi/widget/tableview/kexitableview.h <span style="color: grey">(ca8b10ee4a99a751a86902fbef34d0f00b09fa4f)</span></li>
<li>kexi/widget/tableview/kexitableview.cpp <span style="color: grey">(eab56fc6f42a0519d9e6bfb6b2336707186037fc)</span></li>
<li>kexi/widget/tableview/kexitableview_p.h <span style="color: grey">(e578dfb87fc2d70e9d71cbf92c0e61eb2531e54c)</span></li>
<li>kexi/widget/tableview/kexitimetableedit.h <span style="color: grey">(813cd8a8fde61e1559f18ff8da57e599c94558d9)</span></li>
<li>kexi/widget/tableview/kexitimetableedit.cpp <span style="color: grey">(e5c6f1543d7255f0ddb00379eec69260266c498d)</span></li>
<li>libs/db/CMakeLists.txt <span style="color: grey">(c0d99e8e55d58068eab6b6f09bfddc63e03d55cf)</span></li>
<li>libs/db/chartable.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/db/global.h <span style="color: grey">(b6429593185d1218f590dfae3daf401388fff807)</span></li>
<li>libs/db/global.cpp <span style="color: grey">(eebd6391dcfa018078fe2ebe310fb5b4fbf38c96)</span></li>
<li>libs/db/tableviewcolumn.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/db/tableviewcolumn.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/db/tableviewdata.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/db/tableviewdata.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/db/validator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/db/validator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110162/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>