Review Request 110163: Use KexiDB's TableViewData in the biblio table model

[Jaroslaw Staniek]

Thanks, someone please also carefully review
https://git.reviewboard.kde.org/r/110162/


On 24 April 2013 23:26, Smit Patel <smitpatel24 at gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110163/
>
> Ship it!
>
> Ship It!
>
>
> - Smit
>
> On April 24th, 2013, 9:18 p.m. UTC, Jarosław Staniek wrote:
>   Review request for Calligra, Oleg Kukharchuk, Adam Pigg, Smit Patel,
> Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.
> By Jarosław Staniek.
>
> *Updated April 24, 2013, 9:18 p.m.*
> Description
>
> Use KexiDB's TableViewData in the biblio table model. As a result the model is properly editable.
>
> Moreover, unlike the original solution, thanks to buffering in TableViewData all operations are no longer expensive:
> - row count is O(1),
> - data altering is O(1),
> - data retrieving (individual cells) is O(1)
>
> Filtering works too. The code is also relatively simple.
>
> This patch depends on https://git.reviewboard.kde.org/r/110162 (KexiTableViewColumn and KexiTableViewData from calligradb).
>
>   Testing
>
> Features of the Bibliography Database window work properly.
>
> Not sure about memory leaks, e.g. two cases of Cursor lifetime: m_conn->deleteCursor()
>
>   Diffs
>
>    - libs/kotext/BibliographyTableModel.h (PRE-CREATION)
>    - libs/kotext/BibliographyTableModel.cpp (PRE-CREATION)
>
> View Diff <http://git.reviewboard.kde.org/r/110163/diff/>
>



-- 
regards / pozdrawiam, Jaroslaw Staniek
 Kexi & Calligra & KDE | http://calligra.org/kexi | http://kde.org
 Qt Certified Specialist | http://qt-project.org
 http://www.linkedin.com/in/jstaniek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130425/53f782ac/attachment.htm>